Added a method that allows the generation of report without writing to a file #6
Conversation
|
@cmckni3 any idea what the problem might be here ? This does not seem to be related to the code I have added ? |
|
@nicwillemse Strange. This is actually a bundler error. |
|
|
||
| # Write file | ||
| def run_report(filename, &block) |
There was a problem hiding this comment.
Excellent. This is the reason I reverted ffe38af. I wanted a separate method.
|
@cmckni3 do you have any capacity to look at this now ? |
|
@nicwillemse Thanks a lot for this contribution. I really meant to get around to making this change after I reverted ffe38af due to the control coupling. The coupling made the method more complicated in my opinion and made testing a little awkward. |
|
@nicwillemse I am doing a little investigation. If I can't figure it out in 15 minutes, I will have to wait about 8 hours. |
|
only a pleasure thanks @cmckni3 ! |
|
Running a new Travis build on the container infrastructure to see if it fixes the issue. Strange that Ruby 2.0 didn't have an issue but 1.9.3 and 2.1 did. |
|
@nicwillemse Can you rebase your changes on top of master? The build should pass on Travis after triggering a new build. I will merge your changes after a rebase. 👍 |
…into remove_dependency_on_file_writing
|
@cmckni3 - I have done a merge, I realise a rebase would have been better but there it is |
|
👍 |
|
Will create a new Rubygems release in the morning |
|
Fixes #5 |
|
Awesome - much appreciated @cmckni3 |
|
Published 1.0.0 to rubygems |
Added a method that allows the generation of report without writing to a file