Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profile.ps1: CheckGit does not export $gitLoaded #2191

Closed
XPlantefeve opened this issue Oct 15, 2019 · 0 comments · Fixed by #2199
Closed

profile.ps1: CheckGit does not export $gitLoaded #2191

XPlantefeve opened this issue Oct 15, 2019 · 0 comments · Fixed by #2199

Comments

@XPlantefeve
Copy link

The default $CmderPrompt calls the CheckGit function. CheckGit calls Import-Git with $gitLoaded as a parameter, and then sets $gitLoaded to the result of Import-Git.

But $gitLoaded is internal to CheckGit, and is not modified outside of it, resulting in a posh-git module importation every time the prompt is displayed.
daxgames added a commit to daxgames/cmder that referenced this issue Nov 3, 2019
@daxgames
Fix cmderdev#2191 profile.ps1: CheckGit does not export $gitLoaded
661f59d
@daxgames daxgames mentioned this issue Nov 3, 2019
Merged
@daxgames daxgames closed this as completed Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Git opt out daxgames/cmder
2 participants
@daxgames @XPlantefeve