Twitter unicode problem #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bumping this for @commandline I haven't been able to fix the unescaped HTML problem, but at least this version of the plugin doesn't throw an error when tweets contain certain characters like the current version does. If you have any suggestions for how I might fix the unescaped HTML issue I'm all ears. |
cmdln
approved these changes
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an edge case with the Twitter plugin where if a tweet had a special character--in this case an ellipsis--it threw an error. This edit fixes that, but now some special characters are printing as unescaped HTML (ampersand, angle brackets, etc.). I've tried to fix that but so far no luck. It could also be a quirk of my terminal as other tools I use--like Jlund's Streisand--have the same problem on my computer.