Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for end point overrides #41

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Add support for end point overrides #41

merged 1 commit into from
Jan 31, 2022

Conversation

joepb
Copy link
Member

@joepb joepb commented Jan 31, 2022

Adds support for custom endpoints.

var client = new TextClient(apiKey);
can now be extended to
var client = new TextClient(apiKey, myCustomUri);

For the TextClient, the original constructor remains for binary compatibility.
In the TextClientFactory, the constructor is extended with an optional parameter. Since its use is typical for Dependency Injection, introducing multiple public constructors is not advised.

@joepb joepb linked an issue Jan 31, 2022 that may be closed by this pull request
@EricSmekens
Copy link
Contributor

Cool addition, thanks! Merging.

@EricSmekens EricSmekens merged commit e0b5598 into cmdotcom:master Jan 31, 2022
@joepb joepb deleted the add-endpointoverride branch February 1, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom end points
2 participants