Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dcs parameter #23

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Implement dcs parameter #23

merged 3 commits into from
Jul 7, 2023

Conversation

algra4
Copy link
Contributor

@algra4 algra4 commented Jul 5, 2023

Hello,

Into the documentation of cm.com. We can specify a custom DCS (https://developers.cm.com/messaging/docs/sms#custom-dcs).

However, your implementation doesn't offert this parameter.

This pull request fix the "problem"

@michelmegens
Copy link
Contributor

Hey! First of all: thanks for your contribution!

If you want to, you can also update the version here and the changelog. Then we can release a new package immediately after merging your PR.

@algra4
Copy link
Contributor Author

algra4 commented Jul 5, 2023

Hello @michelmegens

Which version should I use, 2.1.0 or 2.0.2 ?

@michelmegens
Copy link
Contributor

I'd go with 2.1.0, as it's technically a new feature of the/this SDK.

@algra4
Copy link
Contributor Author

algra4 commented Jul 6, 2023

@michelmegens, I've changed the version

@michelmegens michelmegens self-assigned this Jul 7, 2023
@michelmegens michelmegens merged commit 6aff402 into cmdotcom:master Jul 7, 2023
4 checks passed
@algra4 algra4 deleted the implement-dcs branch July 7, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelmegens michelmegens michelmegens approved these changes

Assignees

@michelmegens michelmegens

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@algra4 @michelmegens