Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3 Update #134

Merged
merged 17 commits into from Jun 9, 2019
Merged

Version 3 Update #134

merged 17 commits into from Jun 9, 2019

Conversation

cmfcmf
Copy link
Owner

@cmfcmf cmfcmf commented May 29, 2019

This PR accumulates some breaking changes for version 3, based on #72. I will release version 3 once this PR is merged.

@KarelWintersky
Copy link

Valid :)

@KarelWintersky
Copy link

a little fix:

Must be °F, not an alone F

@cmfcmf
Copy link
Owner Author

cmfcmf commented May 29, 2019

a little fix:

Must be °F, not an alone F

Good point! Fixed in 6c5eee9

@cmfcmf cmfcmf changed the title OWM Version 3 Update Version 3 Update May 29, 2019
@cmfcmf
Copy link
Owner Author

cmfcmf commented May 29, 2019

I am considering to drop support for PHP 5.3, 5.4 and 5.5. Here's why:

  • PHP <= 5.5 is EOL for almost 3 years
  • Many libraries in the ecosystem require PHP 5.6. When I played around with support for PSR-6 Cache (instead of the current custom cache implementation), I quickly ran into issues with cache/array-adapter because it requires at least PHP 5.6.
  • I have only briefly looked into PSR-17 and PSR-18 (HTTP Client), but library support for PHP 5 looks similarly bad over there.

If you are watching this repository, please feel free to comment on this and/or give a 👍 or 👎!

@KarelWintersky
Copy link

All my actual code required PHP 7+

You can drop support for PHP before 7 version :)

@cmfcmf
Copy link
Owner Author

cmfcmf commented Jun 1, 2019

I have now dropped support for PHP < 7 completely, since psr/http-client requires at least PHP 7.0. There are two things left for me to do before merging this PR and releasing 3.0.0:

  • test the weather history data integration impossible because it requires a paid API key. I therefore removed weather history integration.
  • use new PHP features (types, short array syntax, ...) postponed

I am removing support for querying weather history, because there is no way to receive a free API key to test it.
@cmfcmf cmfcmf merged commit 45fab12 into master Jun 9, 2019
@cmfcmf cmfcmf deleted the v3 branch June 9, 2019 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dealing with Internal error: 500001
2 participants