Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 404 Not Found detection #151

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Fix 404 Not Found detection #151

merged 2 commits into from
Jul 30, 2020

Conversation

robjuz
Copy link
Contributor

@robjuz robjuz commented Jul 24, 2020

fix #150

@cmfcmf
Copy link
Owner

cmfcmf commented Jul 30, 2020

Looks good, thank you! IIRC, the API up to some point always returned json errors, even when the requested format was XML. It seems like OWM fixed that. Regardless, using strpos instead of a verbatime JSON string is very reasonable. 👍

@cmfcmf cmfcmf changed the title Update OpenWeatherMap.php Fix 404 Not Found detection Jul 30, 2020
@cmfcmf cmfcmf merged commit bf32d21 into cmfcmf:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OWMNotFoundException never thrown
2 participants
@robjuz @cmfcmf