Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPTIONS related tests failing as response no longer has a body #132

Closed
cmorten opened this issue Jul 2, 2021 · 1 comment · Fixed by #133
Closed

OPTIONS related tests failing as response no longer has a body #132

cmorten opened this issue Jul 2, 2021 · 1 comment · Fixed by #133
Labels
tests

Comments

@cmorten
Copy link
Owner

cmorten commented Jul 2, 2021 •
edited

Issue

Setup:

deno 1.11.4 (release, x86_64-apple-darwin)
v8 9.1.269.35
typescript 4.3.2

Details

Tests are failing on the 1.11.x Deno versions because fetch has been updated to no longer return a body in it's response.

REFs:
@cmorten cmorten added the tests label Jul 2, 2021
@asos-craigmorten
Copy link
Collaborator

PR raised for fix: denoland/deno#11242

@cmorten cmorten mentioned this issue Jul 13, 2021
Merged
2 tasks
cmorten added a commit that referenced this issue Jul 13, 2021
@cmorten
[#132] std lib and deno upgrade (#133)
689779e 
* feat: std@0.101.0
* feat: Deno 1.12.0
* test: cannot set custom host headers for fetch anymore - impacts superdeno
* test: hostname tests can't set custom HOST anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#132] std lib and deno upgrade cmorten/opine
2 participants
@cmorten @asos-craigmorten