Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fetch): OPTIONS should be allowed a non-null body #11242

Merged
merged 3 commits into from
Jul 5, 2021
Merged

fix(fetch): OPTIONS should be allowed a non-null body #11242

merged 3 commits into from
Jul 5, 2021

Conversation

cmorten
Copy link
Contributor

@cmorten cmorten commented Jul 3, 2021

Reverts changes from: #11003
Related to: #10990

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@kitsonk
Copy link
Contributor

kitsonk commented Jul 4, 2021

We should either revert #11003 @lucacasonato or this PR needs to add CONNECT so it matches the specification properly.

@kitsonk kitsonk requested a review from lucacasonato July 4, 2021 23:34
@cmorten
Copy link
Contributor Author

cmorten commented Jul 5, 2021 •
edited

We should either revert #11003 @lucacasonato or this PR needs to add CONNECT so it matches the specification properly.

Happy to add CONNECT - indeed I had it in there, but then realised that code path was likely never reached due to Deno throwing a “method is forbidden” like error.

REFs:

I guess regardless of other behaviours we can align this particular unit to the spec, but we will be unable to test the behaviour because the throw masks it

cmorten
cmorten commented Jul 5, 2021
View reviewed changes
extensions/fetch/26_fetch.js Outdated Show resolved Hide resolved
@asos-craigmorten asos-craigmorten mentioned this pull request Jul 5, 2021
Closed
lucacasonato
lucacasonato approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@lucacasonato lucacasonato merged commit a6c840d into denoland:main Jul 5, 2021
@cmorten cmorten deleted the fix/fetch-issue-10990-connect-null-body branch July 5, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cmorten @CLAassistant @kitsonk @lucacasonato