Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-1] Decouple SuperOak from Oak v5.0.0 to prevent type errors. #2

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

asos-craigmorten
Copy link
Collaborator

Issue

ISSUE-1

Details

Decouples SuperOak from Oak v5.0.0.

As Oak develops, so does it's types, so to use any particular version of Oak to determine whether an object is an instance of it's Application will inevitably fail as what an Application is will change (esp. with strong typing).

This patch introduces some duck typing to determine if the passed app has the minimal desired shape of an Oak Application instance.

This should be fortified in future as the duck-typing is somewhat fragile and still susceptible to major changes in the Oak framework.

CheckList

  • PR starts with [ISSUE_ID] and branch name is e.g. feature/description (see branching strategy in CONTRIBUTING).
  • Squashed commit message is prefixed with [ISSUE_ID] as above.
  • Has been tested (where required) before merge to develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant