[ISSUE-1] Decouple SuperOak from Oak v5.0.0 to prevent type errors. #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
ISSUE-1
Details
Decouples SuperOak from Oak v5.0.0.
As Oak develops, so does it's types, so to use any particular version of Oak to determine whether an object is an instance of it's
Application
will inevitably fail as what anApplication
is will change (esp. with strong typing).This patch introduces some duck typing to determine if the passed
app
has the minimal desired shape of an OakApplication
instance.This should be fortified in future as the duck-typing is somewhat fragile and still susceptible to major changes in the Oak framework.
CheckList