Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR, Update dependencies. #1

Closed
wants to merge 3 commits into from
Closed

Fix PR, Update dependencies. #1

wants to merge 3 commits into from

Conversation

luca992
Copy link

@luca992 luca992 commented Jun 8, 2022

There was a bunch of build issues with your PR. If fixed the build and further updated ktor and plugins

Edit:

If you build as is:

  1. gradlePluginPortal() isn't added to buildscript.repositories and it fails there
  2. Build fails if extra publishing properties aren't present (which isn't necessarily a bug, but it's easy enough to fix by doing as String -> as String? ?: "")
  3. The error: Minimum supported Gradle version is 7.2. Current version is 7.1.1. (I updated to 7.4.2)
  4. bodyAsChannel() uses the wrong import in HttpFetcher
> Task :kamel-image:compileDebugKotlinAndroid FAILED
e: /Users/lucaspinazzola/Projects/Kamel/kamel-image/src/androidMain/kotlin/io/kamel/image/fetcher/ResourcesFetcher.kt: (25, 12): Unresolved reference: ExperimentalIoApi
e: /Users/lucaspinazzola/Projects/Kamel/kamel-image/src/androidMain/kotlin/io/kamel/image/fetcher/ResourcesFetcher.kt: (25, 12): An annotation argument must be a compile-time constant
e: /Users/lucaspinazzola/Projects/Kamel/kamel-image/src/androidMain/kotlin/io/kamel/image/mapper/ResourcesIdMapper.kt: (10, 73): This annotation is not applicable to target 'type usage'
e: /Users/lucaspinazzola/Projects/Kamel/kamel-image/src/androidMain/kotlin/io/kamel/image/mapper/ResourcesIdMapper.kt: (16, 68): Cannot find a parameter with this name: encodedPath
  1. android gradle plugin 7.1.3 fails with a strange must use a different android studio version.. I downgraded back to 7.0.4, which is what all compose-jb examples use

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant