Disabled the TED and TRE tables by default. #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aehart
changed the title
skinnari
approved these changes
Oct 19, 2020
tomalin
pushed a commit
that referenced
this pull request
Dec 8, 2020
* Added a flag for enabling the application of the TED and TRE tables. * Fixed code format issues. * Updated bestTCID to not depend on the number of bits used to represent TCIDs. * Removed confusing comment.
aryd
pushed a commit
that referenced
this pull request
Dec 9, 2020
* Added a flag for enabling the application of the TED and TRE tables. * Fixed code format issues. * Updated bestTCID to not depend on the number of bits used to represent TCIDs. * Removed confusing comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Port to the L1TK-dev-11_2_0_pre6 branch of cms-sw#30847, which disables the lookup tables in the TrackletEngineDisplaced and TripletEngine, which were found to cause excessive memory consumption.
This issue was discussed during the 22 July algorithm meeting:
https://indico.cern.ch/event/941060/#27-change-to-displaced-trackin
PR validation:
The desired effect on memory consumption is seen after this change, as detailed in the discussion on cms-sw#30818. I also ran the usual
scram b code-checks,scram b code-format, andcmsCodeRulesChecker.py, which do not produce any warnings.