Added a flag for enabling the application of the TED and TRE tables.

[aehart]

PR description:

This is a port to CMSSW_11_2_X of #30818, which disables the lookup tables in the TrackletEngineDisplaced and TripletEngine, which were found to cause excessive memory consumption.

[cmsbuild]

@aehart, CMSSW_11_2_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30847/17196

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/TrackFindingTracklet/src/Tracklet.cc modified in PR(s): [Clang tidy] Apply checks for l1 #30802

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30847/17196/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30847/17196/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[silviodonato]

@aehart please apply the code-check fixes and propagate them to #30818 too. Thanks

[silviodonato]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30847/17199

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/TrackFindingTracklet/src/Tracklet.cc modified in PR(s): [Clang tidy] Apply checks for l1 #30802

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-21-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8180/console Started: 2020/07/21 17:54

[cmsbuild]

A new Pull Request was created by @aehart (Andrew Hart) for master.

It involves the following packages:

L1Trigger/TrackFindingTracklet

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 2368e45
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8008d/8180/summary.html
CMSSW: CMSSW_11_2_X_2020-07-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

+1
Tested at: 366103f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8008d/8573/summary.html
CMSSW: CMSSW_11_2_X_2020-08-04-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8008d/8573/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2612401
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2612352
• DQMHistoTests: Total skipped: 48
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[silviodonato]

kind reminder @cms-sw/l1-l2

[rekovic]

pending decision on #30818

[silviodonato]

I'm converting this PR as a draft just to remove this from the ORP spreadsheet. Of course feel free to open it back if needed.

[silviodonato]

@rekovic @aehart @skinnari @tomalin I missed your comments in #30818 because I was on holiday. As soon as we managed to start the HLT TDR re-reco production, we decided to keep everything unchanged to avoid any possible risk.

I think it would be good to have it in master. If you want to reactivate this PR, @aehart please push on the button "Ready for review"