Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of problematic Supercrystals in Endcaps for LED Quality plot #2

Merged
merged 1 commit into from Mar 30, 2022

Conversation

abhih1
Copy link
Contributor

@abhih1 abhih1 commented Mar 28, 2022

This PR adds to the dedicated data repository, the data file containing the list of ix, iy, iz coordinates and the raw detector ID of the Supercrystals in the Ecal Endcaps which are known to be problematic.
This list is used to update the quality cuts on these supercrystals in the LED Quality plots.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @abhih1 (Abhirami Harilal) for branch main.

@smuzaffar, @emanueleusai, @iarspider, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@jfernan2
Copy link

+1

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6068d3/23486/summary.html
COMMIT: 75f4457
CMSSW: CMSSW_12_4_X_2022-03-28-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/DQM-EcalMonitorClient/2/23486/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6068d3/23486/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6068d3/23486/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3583670
  • DQMHistoTests: Total failures: 20138
  • DQMHistoTests: Total nulls: 332
  • DQMHistoTests: Total successes: 3563178
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1328.2419999999984 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 1461.475 KiB HLT/JME
  • DQMHistoSizes: changed ( 11634.0,... ): 1.887 KiB HLT/Filters
  • DQMHistoSizes: changed ( 39434.0,... ): -2527.102 KiB HGCAL/HGCalValidator
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link

@abhih1 I think that this list should get merged together with #37378: correct?
And then, it should be also made available to the backports #37404 (12_3_X) and #37380 (12_2_X)

@abhih1
Copy link
Contributor Author

abhih1 commented Mar 30, 2022

@perrotta Yes, that's right.

@perrotta
Copy link

+1

  • Needed by #37378, just merged in master

@perrotta
Copy link

ping bot

@perrotta
Copy link

merge

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next main IBs (tests are also fine). This pull request will be automatically merged.

@qliphy
Copy link

qliphy commented Apr 1, 2022

@smuzaffar Would you please make a cmsdist PR for 12_2_X and 12_3_X?

@smuzaffar
Copy link
Contributor

FYI @qliphy
12.2.X: cms-sw/cmsdist#7740
12.3.X: cms-sw/cmsdist#7739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants