Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hwloc to version 2.7.1 #7714

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 24, 2022

2.7.1 fixes several issues, all users are encouraged to upgrade.
The following is a summary of the changes since v2.7.0.

Version 2.7.1

  • Workaround crashes when virtual machines report incoherent x86 CPUID
    information about numbers of cores and threads.
    Thanks to Peter Bense for the report.
  • Use setenv() instead of putenv() when trying to force enable oneAPI L0
    support, to avoid issues with applications that touch the environment,
    thanks to Josh Hursey for the patch.
  • Add some warnings at the end of configure when GPU libraries are
    missing on the system or their path is missing in the environment.

2.7.1 fixes several issues, all users are encouraged to upgrade.
The following is a summary of the changes since v2.7.0.

Version 2.7.1
-------------
* Workaround crashes when virtual machines report incoherent x86 CPUID
  information about numbers of cores and threads.
  Thanks to Peter Bense for the report.
* Use setenv() instead of putenv() when trying to force enable oneAPI L0
  support, to avoid issues with applications that touch the environment,
  thanks to Josh Hursey for the patch.
* Add some warnings at the end of configure when GPU libraries are
  missing on the system or their path is missing in the environment.
@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 24, 2022

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_12_4_X/master.

@smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 24, 2022

type bugfix

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-830a17/23352/summary.html
COMMIT: 4f2951a
CMSSW: CMSSW_12_4_X_2022-03-23-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7714/23352/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test materialBudgetTrackerPlots had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3579 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695650
  • DQMHistoTests: Total failures: 52666
  • DQMHistoTests: Total nulls: 58
  • DQMHistoTests: Total successes: 3642904
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 25, 2022

---> test materialBudgetTrackerPlots had ERRORS

This keeps coming up in every PR test... would it be possible to disable it until somebody fixes it ?

@perrotta
Copy link
Contributor

---> test materialBudgetTrackerPlots had ERRORS

This keeps coming up in every PR test... would it be possible to disable it until somebody fixes it ?

@fwyzard I'm scrolling through the open PRs and the IBs and I can't find track of this unit test error elsewhere. Could you please point me the other places where you encountered it? We can open an issue, then, to involve the responsibles of that test, supposedly @cms-sw/geometry-l2

@smuzaffar
Copy link
Contributor

@perrotta , it mostly failed for cmsdist/external PR testing

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

please test
there are too many comparison differences, lets re-run using newer IB

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 25, 2022

Could you please point me the other places where you encountered it? We can open an issue, then, to involve the responsibles of that test, supposedly @cms-sw/geometry-l2

@perrotta sure, as Shahzad mentioned it happens in many externals-related PRs:

https://github.com/cms-sw/cmsdist/pulls?q=is%3Apr+%22test+materialBudgetTrackerPlots+had+ERRORS%22+

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-830a17/23380/summary.html
COMMIT: 4f2951a
CMSSW: CMSSW_12_4_X_2022-03-24-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7714/23380/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3552 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695644
  • DQMHistoTests: Total failures: 50011
  • DQMHistoTests: Total nulls: 61
  • DQMHistoTests: Total successes: 3645550
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.096 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.516 KiB HLT/Filters
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants