Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UL2018 scales and smearing correction files #9

Merged
merged 1 commit into from Oct 27, 2020

Conversation

jainshilpi
Copy link
Contributor

These are scales and smearing files for e/gamma for UL2018

@cmsbuild
Copy link

A new Pull Request was created by @jainshilpi for branch master.

@cmsbuild, @smuzaffar, @santocch, @mrodozov can you please review it and eventually sign? Thanks.
@afiqaize, @Sam-Harper, @varuns23, @sobhatta this is something you requested to watch as well.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor

any cmssw PR to test with ?

@jainshilpi
Copy link
Contributor Author

yes the PR is just created:
cms-sw/cmssw#31936

@cmsbuild
Copy link

cmsbuild commented Oct 26, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#31936

@cmsbuild
Copy link

+1
Tested at: a699ca7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-976e1c/10284/summary.html
CMSSW: CMSSW_11_2_X_2020-10-25-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link

Comparison job queued.

@cmsbuild
Copy link

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-976e1c/10284/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 42 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544110
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2544081
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@mrodozov
Copy link
Contributor

@slava77 there are 42 differences in comparison, would you check it please ?

@jainshilpi
Copy link
Contributor Author

Differences are expected since these are new scale and smearing corrections. Validation plots can be seen here: https://shilpi-afs.web.cern.ch/shilpi-afs/13TeV/2020/SSvalidation/UL2018/19Oct/

@santocch
Copy link

+1

@mrodozov
Copy link
Contributor

+externals
two new files. actual changes will be made in cmssw anyway

@mrodozov mrodozov merged commit a9467f7 into cms-data:master Oct 27, 2020
@cmsbuild
Copy link

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@jainshilpi
Copy link
Contributor Author

jainshilpi commented Oct 28, 2020

We would need a back-port for UL2018 as was done for UL2017 (#30199). If its agreed, then I can go ahead and do a back-port.

@cmsbuild
Copy link

cmsbuild commented Nov 3, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#32002

@cmsbuild
Copy link

cmsbuild commented Nov 3, 2020

+1
Tested at: a699ca7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49b1d2/10476/summary.html
CMSSW: CMSSW_10_6_X_2020-11-03-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link

cmsbuild commented Nov 3, 2020

Comparison job queued.

@cmsbuild
Copy link

cmsbuild commented Nov 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49b1d2/10476/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 79 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214664
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214327
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants