UL scale and smearing for nanoAOD photons and electrons (2017 and 2018)

[jainshilpi]

This PR updates the UL2017 and 2018 scale and smearing corrections for nanoAOD. A few updates to:
(1) nano_cff.py
(2) photon_cff.py
(3) electron_cff.py

All runTheMatrix runs fine. Also tested on 136.8522 which was not included in the limited runTheMatrix.py.

@mariadalfonso

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31974/19435

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): PuppiMET with PUPPIv15 and UL17 PUID #31927, PPS nanoAOD #31531

[cmsbuild]

A new Pull Request was created by @jainshilpi for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @peruzzim, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-27-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10360/console Started: 2020/10/28 16:50

[cmsbuild]

-1

Tested at: 4cd0f9c

CMSSW: CMSSW_11_2_X_2020-10-27-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-558687/10360/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following workflows:
10824.0 step6

runTheMatrix-results/10824.0_TTbar_13+2018+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step6_TTbar_13+2018+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

[cmsbuild]

Comparison job queued.

[mariadalfonso]

seems that we need to wait for the
cms-data/EgammaAnalysis-ElectronTools#9
to appear in a new build

edm::FileInPath unable to find file EgammaAnalysis/ElectronTools/data/ScalesSmearings/Run2018_29Sep2020_RunFineEtaR9Gain_scales.dat anywhere in the search path.

[cmsbuild]

+1
Tested at: 4cd0f9c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-558687/10384/summary.html
CMSSW: CMSSW_11_2_X_2020-10-29-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-558687/10384/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-558687/1325.61_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOAODMC2017_106XMiniAODv1
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-558687/1325.81_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOEDMMC2017_106XMiniAODv1+HARVESTNANOAODMC2017_106XMiniAODv1
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-558687/136.8522_RunJetHT2018A_nanoUL+RunJetHT2018A_nanoUL+NANOEDM2018_106Xv1+HARVESTNANOAOD2018_106Xv1

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 73 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2544092
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2544069
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[mariadalfonso]

[mariadalfonso]

+xpog
scale and smearing applied to electron and photon for UL 16-18, size of the effect shown in #31974 (comment)
nano from previous mini (94X.. and 102X) are untouched

[mariadalfonso]

@jainshilpi
can you make the backport to 10_6 of this PR, thanks

[silviodonato]

merge
@santocch please have a look

[jainshilpi]

@jainshilpi
can you make the backport to 10_6 of this PR, thanks

@mariadalfonso its on the way - will create a PR soon.

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.