Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating DECAY and evt files from evtgen 2.0 #16

Merged
merged 1 commit into from Mar 31, 2021

Conversation

alberto-sanchez
Copy link
Contributor

@alberto-sanchez alberto-sanchez commented Mar 31, 2021

Moving files from cmssw
cms-sw/cmssw#33313

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alberto-sanchez (Alberto Sanchez Hernandez) for branch master.

@SiewYan, @smuzaffar, @mkirsano, @mrodozov, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

test parameters:

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

+externals
these files are moved from cms-sw/cmssw here. this can be merged now

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-136259/13904/summary.html
COMMIT: e07c901
CMSSW: CMSSW_11_3_X_2021-03-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/GeneratorInterface-EvtGenInterface/16/13904/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • #33288 @slomeo: DTGeometryESProducer Update
  • #33302 @cms-tau-pog: Updates to tauID python tool (followup)
  • #33270 @swagata87: Technical optimisation of e/gamma (local)covariances function (11_3_X)
  • #33287 @bsunanda: Phase2-hgx280X Modify the tests in Geometry/HGCalCommonData/test to declare automatic creation of cfi
  • #33286 @bsunanda: Phase2-hgx280 Check SIM step for V15 Geometry of HGCal

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-136259/13904/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-136259/13904/git-merge-result

CMS Clang-Tidy warnings: There are 20 Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-136259/13904/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-136259/541.0_BuToKstarJPsiToMuMu_forSTEAM_13TeV+BuToKstarJPsiToMuMu_forSTEAM_13TeV+HARVESTGEN
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-136259/545.0_BsToMuMu_forSTEAM_13TeV+BsToMuMu_forSTEAM_13TeV+HARVESTGEN

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2640841
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2640812
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@agrohsje
Copy link

agrohsje commented Apr 1, 2021

+generators

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@agrohsje
Copy link

agrohsje commented Apr 1, 2021

@alberto-sanchez i cannot find the comment anymore so let me calrify: will you make a back-port to 10_6? if so, should 2020 files be a requirement for ul requests?
@efeyazgan @jordan-martins FYI in case we need to update gen checking script but this depends on feedback from alberto

@alberto-sanchez
Copy link
Contributor Author

@agrohsje, it is not planned. The DECAY and evt files can be used transparently between 2.0 and 1.6, howver the usage of 2.0 was not planned upto Run3. At least that was the consensus during my presentation in BPH last December.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants