Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing data files from interface #33317

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

alberto-sanchez
Copy link
Member

PR description:

The DECAY end evt files were moved out. They should be available in cms-data/GeneratorInterface-EvtGenInterface.
This should take care of #33313
It should be tested together with cms-data/GeneratorInterface-EvtGenInterface#16

PR validation:

at least workflows 541.0,545.0

@smuzaffar
Copy link
Contributor

test parameters:

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33317/21852

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alberto-sanchez (Alberto Sanchez Hernandez) for master.

It involves the following packages:

GeneratorInterface/EvtGenInterface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb358c/13894/summary.html
COMMIT: 7288e31
CMSSW: CMSSW_11_3_X_2021-03-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33317/13894/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb358c/13894/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb358c/13894/git-merge-result

CMS Clang-Tidy warnings: There are 20 Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb358c/13894/llvm-analysis/cmsclangtidy.txt for details.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-bb358c/541.0_BuToKstarJPsiToMuMu_forSTEAM_13TeV+BuToKstarJPsiToMuMu_forSTEAM_13TeV+HARVESTGEN
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-bb358c/545.0_BsToMuMu_forSTEAM_13TeV+BsToMuMu_forSTEAM_13TeV+HARVESTGEN

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2640841
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2640812
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@silviodonato , @qliphy this should be merged with cms-sw/cmsdist#6780

@smuzaffar
Copy link
Contributor

code-checks

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33317/21865

  • This PR adds an extra 12KB to repository

@cms-sw cms-sw deleted a comment from cmsbuild Apr 1, 2021
@agrohsje
Copy link

agrohsje commented Apr 1, 2021

+generators

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 0cf77aa into cms-sw:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants