-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing data files from interface #33317
Conversation
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33317/21852
|
A new Pull Request was created by @alberto-sanchez (Alberto Sanchez Hernandez) for master. It involves the following packages: GeneratorInterface/EvtGenInterface @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb358c/13894/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: CMS Clang-Tidy warnings: There are 20 Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb358c/13894/llvm-analysis/cmsclangtidy.txt for details.
Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
@silviodonato , @qliphy this should be merged with cms-sw/cmsdist#6780 |
code-checks |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33317/21865
|
+generators |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
merge |
PR description:
The DECAY end evt files were moved out. They should be available in cms-data/GeneratorInterface-EvtGenInterface.
This should take care of #33313
It should be tested together with cms-data/GeneratorInterface-EvtGenInterface#16
PR validation:
at least workflows 541.0,545.0