Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RecoBTag-Combined to new tag #4540

Closed

Conversation

mrodozov
Copy link
Contributor

Description available here: cms-data/RecoBTag-Combined#19
Fixes #4537

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_4_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 29, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31910/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 29, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#25376
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31911/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4540/31910/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 170 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3131839
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3131634
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@slava77
Copy link
Contributor

slava77 commented Dec 3, 2018

Conflicting files
data/data-build-github-new.txt

@mrodozov @smuzaffar
should this be rebased and re-tested or is this a new way of making data specs?

It looks like the file in the release branch https://github.com/cms-sw/cmsdist/tree/IB/CMSSW_10_4_X/gcc700/data did not change since a week before this PR was made.
Is the testing script able to pick up this PR version and not confuse it with the baseline?

@slava77
Copy link
Contributor

slava77 commented Dec 3, 2018

based on the comparisons, it looks like the change is good to go: only miniAOD slimmedJetsAK8 jets have changes in jet tags in expected places.

@fabiocos
Copy link
Contributor

fabiocos commented Dec 4, 2018

@smuzaffar it looks like this PR needs to be rebased because of a conflict, which holds also the merge of cms-sw/cmssw#25376

mrodozov added a commit that referenced this pull request Dec 4, 2018
@mrodozov
Copy link
Contributor Author

mrodozov commented Dec 4, 2018

@slava77 yes @smuzaffar introduced new way of making changes for data packages, all of them being in a few files as a single record instead of one file per data pkg, which introduces this problem when we have multiple data pkg PRs at the same time.

mrodozov added a commit that referenced this pull request Dec 4, 2018
mrodozov added a commit that referenced this pull request Dec 4, 2018
Reopen #4540 with changes to avoid conflict (faster than rebase)
@mrodozov
Copy link
Contributor Author

mrodozov commented Dec 4, 2018

should this be rebased and re-tested

closing this one in favor of #4551

@mrodozov mrodozov closed this Dec 4, 2018
@smuzaffar smuzaffar deleted the update-data-recobtag-combined branch December 13, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants