Deep csv phase ii fix

[dseith]

fixed the flight Distance variables in the training of the DeepCSV_PhaseII model.

Despite the weights of the model, also the offsets and scales for the flightDistance variables have changed:

https://github.com/dseith/RecoBTag-Combined/blob/966f9531ab99acb7396378c199b4a4ccb3937b1e/DeepCSV_PhaseII.json#L315
https://github.com/dseith/RecoBTag-Combined/blob/966f9531ab99acb7396378c199b4a4ccb3937b1e/DeepCSV_PhaseII.json#L320
https://github.com/dseith/RecoBTag-Combined/blob/966f9531ab99acb7396378c199b4a4ccb3937b1e/DeepCSV_PhaseII.json#L325
https://github.com/dseith/RecoBTag-Combined/blob/966f9531ab99acb7396378c199b4a4ccb3937b1e/DeepCSV_PhaseII.json#L330

See also here: cms-sw/cmssw#26072 (comment)

[cmsbuild]

A new Pull Request was created by @dseith (David Seith) for branch master.

@perrotta, @smuzaffar, @mrodozov, @cmsbuild, @slava77, @gudrutis can you please review it and eventually sign? Thanks.
@smoortga, @acaudron, @HeinerTholen, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

external issue cms-sw/cmsdist#4950

[slava77]

@mrodozov @smuzaffar
I think that this can be merged so that we can proceed to having a cmsdist PR available for tests of the cmssw PR.
(assuming that we are still in the old setup where cms-data PR can not be tested by itself and a cmsdist PR is needed)

[smuzaffar]

@slava77 , you can now test cms-data PRs too. If there is already a cmssw PR to test this then please start the tests by adding comment
please test with cms-data/RecoBTag-Combined#23
if this Pr should be tested alone then just comment here please test

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#26072
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/128/console Started: 2019/05/09 17:48

[slava77]

@slava77 , you can now test cms-data PRs too. If there is already a cmssw PR to test this then please start the tests by adding comment
please test with cms-data/RecoBTag-Combined#23
if this Pr should be tested alone then just comment here please test

Nice.
I started the tests.

[cmsbuild]

-1

Tested at: 966f953

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3be52ce
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23/128/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23/128/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf893c/128/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test testConditionDatabase_2 had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3be52ce
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23/128/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23/128/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf893c/128/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 108 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 129
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211631
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

+1

based on tests summarized in cms-sw/cmssw#26072 (comment)

[smuzaffar]

+externals
unit test failure is not related to this PR ( see cms-sw/cmssw#26741 )

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[fabiocos]

merge