-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated json for DeepCSV Phase 2 model #26072
Conversation
added correct json for PhaseII to pfDeepCSVJetTags_cfi.py
Update pfDeepCSVJetTags_cfi.py
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26072/8630
|
A new Pull Request was created by @dseith (David Seith) for master. It involves the following packages: RecoBTag/Combined @cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
we need a data PR in the cms-data/RecoBTag-Combined repository |
The PR is already there: cms-btv-pog/RecoBTag-Combined#3 |
Ah my bad |
I've now made the PR to cms-data/RecoBTag-Combined: cms-data/RecoBTag-Combined#20 |
please test with cms-sw/cmsdist#4752 |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@smuzaffar I see in the compile log |
Compared to the previous #26072 (comment), it seems like we have some improvements. Here are comparisons relative to the previous version of the training: Compared to the current baseline, |
+1 for #26072 3be52ce combined with cms-data/RecoBTag-Combined#23 966f953
|
@kpedro88 the ball is in your field now... |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge |
A pull request with the new json for DeepCSV Phase 2 has been made to: https://github.com/cms-btv-pog/RecoBTag-Combined
Accordingly, the name of the json in this file is updated to match the now available Phase 2 json.