Moving fastjet threading PR to cms/v3.1.0 #8
Conversation
Changes needed to allow independent instances to run on seperate threads
We want to compile third party libraries using these fastjet headers using compiler options that may not include C++11 support but still link to our libraries built with C++11. This requires all C++11 constructs to either be removed from the headers or hidden (in the case where their pre C++11 equivalents are binary compatible). This change also attempts to make it possible to compile all of fastjet with a non C++11 compiler. In addition, we have attempted to fulfill the request by the fastjet maintainers to comment the CMS changes and explicitly state that the changes are not sanctioned by the fastjet maintainers.
Hide C++11 features from header files
typo: fixed the atomic_counter copy constructor
|
Results are ready: |
|
@nclopezo can you re base this on top of cms/v3.1.0? We can then discuss in On mar 11 nov 2014 at 14:31 David Mendez notifications@github.com wrote:
|
|
Results are ready: |
|
or also the ones that come from https://github.com/cms-externals/fastjet/commits/cms/v3.0.3 ? |
|
We want everything but the merge commits. On Tue Nov 11 2014 at 4:37:50 PM David Mendez notifications@github.com
|
|
I rebased it here: #9 |
|
A new Pull Request was created by @rappoccio for branch cms/v3.1.0. Moving fastjet threading PR to cms/v3.1.0 @cmsbuild, @Degano can you please review it and eventually sign? Thanks. external issue cms-sw/cmsdist#1760 |
|
same as #11 |
Correction of #7