-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major JME developments for 73x #6273
Conversation
…going to contain more stuff
…due to the ValueMap constraints
…some test sequences
A new Pull Request was created by @rappoccio for CMSSW_7_3_X. Major JME developments for 73x It involves the following packages: CommonTools/PileupModules The following packages do not have a category, yet: CommonTools/PileupModules @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
Hi Sal, Please add a summary of physics and technical performance changes from this PR, |
On 1000 events, some speed improvements for fastjet 3.1.0 are : So, reductions of 0.2-2.0 are observed depending on the cone size. The algorithms have been studied in We haven't decided exactly which to implement, but overall similar pileup mitigation performances have been observed from PUPPI, constituent subtraction, and soft killer, in particularly in conjunction with any grooming technique. PUPPI seems to have the most benefits in one package, though, so that's most likely the way forward. |
Which IB has the new version of the fastjet?
|
None yet, still waiting on @Dr15Jones and @ktf for integration of both externals. |
uhm, ok. |
We are indeed on hold, this was just to get things moving. As far as I can tell with the tests I got from Chris, we should be good to go with the fastjet integration. |
So, the compilation error due to missing SoftKiller is due to fastjet-contrib I see it's in https://fastjet.hepforge.org/contrib/contents/1.014.html |
@slava77 : correct, I mentioned the fastjet-contrib requirement above. I can also do the rebase. Grrr. Give me a little while. |
I cannot get this branch to rebase correctly. Thus I will close this PR and open a new one. |
This PR contains a large number of JME developments for 73x :
Two notes :
Also adding @violatingcp and @nhanvtran to watch this.
Final note : This seems to be stuck "Checking mergeability...". I have updated to CMSSW_7_3_X_2014-11-07-0200 and it merges fine, so I presume this is a github issue.