uGMT intermediate muon upgrades for DQM #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rekovic since this touches only the intermediate muons that are used only by the DQM could we make a direct PR to CMSSW in order for the DQM people to pick it up for deployment at P5? |
|
@thomreis |
|
I have made the PRs directly to CMSSW. They do not need to be signed by DQM since DQM packages are not touched. @rekovic can you launch the tests please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the uGMT unpacker and synchronises the data format of the emulator and the FW for the intermediate muons.
The unpacker was missing one link with intermediate muons.
The unpacked data had the iso value set to 0 for intermediate muons, while the emulator was setting it to -1.