Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-decorrelated DeepDoubleX tagger scores #371

Merged
merged 5 commits into from Sep 20, 2019

Conversation

dmajumder
Copy link

PR description:

The previous DeepDoubleX tagger added to NanoAOD (PR#347) was for the mass-decorrelated version.

This PR includes the non-decorrelated version in NanoAOD.

The non-mass-decorrelated version gives a better performance than the mass-correlated version:
https://indico.cern.ch/event/795581/contributions/3337046/attachments/1836661/3009499/CMS_HFW_Dubrovnik.pdf#page=12

Depending on the analysis selections, the user has a choice of either.

PR validation:

Tested in CMSSW_10_2_14 following the recipe in:
https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3659/1.html

@gpetruc-bot
Copy link

@gpetruc-bot
Copy link

Please update PhysicsTools/NanoAOD/python/nanoDQM_cfi.py: take this patch or run prepareDQM.py -d -u nano_file_mc.root, and then if needed adjust the plot range using some human common sense.

Copy link

@gpetruc-bot gpetruc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic test report for 968715

Code integration

Code checks not run for this PR (no source files modified)

Please update PhysicsTools/NanoAOD/python/nanoDQM_cfi.py: take this patch or run prepareDQM.py -d -u nano_file_mc.root, and then if needed adjust the plot range using some human common sense.

Tests

  • Long test data102X (10000 events): passed, no significant changes; dqm plots: all, diff
  • Long test data80X (10000 events): passed, no significant changes; dqm plots: all, diff
  • Long test data80Xhip (3000 events): passed, no significant changes; dqm plots: all, diff
  • Long test data94X (10000 events): passed, no significant changes; dqm plots: all, diff
  • Long test data94X2016 (10000 events): passed, no significant changes; dqm plots: all, diff
  • Long test data94Xv2 (10000 events): passed, no significant changes; dqm plots: all, diff
  • Long test mc102X (9000 events): passed, no significant changes; dqm plots: all, diff
  • Long test mc80X (10000 events): passed, no significant changes; dqm plots: all, diff
  • Long test mc94X (10000 events): passed, no significant changes; dqm plots: all, diff
  • Long test mc94X2016 (9000 events): passed, no significant changes; dqm plots: all, diff
  • Long test mc94Xv2 (9000 events): passed, no significant changes; dqm plots: all, diff
  • Test mc_94Xv2: passed
  • Test mc_102X: passed
  • Test data_94X: passed
  • Test data_102X: passed

Disk size report

Sample kb/event ref kb/event diff
TTbar MC 102X 1.834 1.830 0.004 ( +0.2% )
TTbar MC 94Xv1 1.928 1.924 0.003 ( +0.2% )
TTbar MC 94Xv2 1.961 1.956 0.004 ( +0.2% )
TTbar MC 94X2016 1.749 1.744 0.005 ( +0.3% )
TTbar MC 80X 1.903 1.901 0.002 ( +0.1% )
Data 102X 0.972 0.963 0.009 ( +0.9% )
Data 94Xv1 0.918 0.913 0.005 ( +0.5% )
Data 80X 0.794 0.793 0.002 ( +0.2% )
Data 80X, Mu Run2016E 0.775 0.775 0.000 ( +0.0% )

@peruzzim peruzzim changed the title Nano aod cmssw 10 2 x Add non-decorrelated DeepDoubleX tagger scores Aug 22, 2019
PhysicsTools/NanoAOD/python/jets_cff.py Outdated Show resolved Hide resolved
@dmajumder
Copy link
Author

@peruzzim hope this is OK.
BTW on the above comment for the DQM:
"Please update PhysicsTools/NanoAOD/python/nanoDQM_cfi.py: take this patch or run prepareDQM.py -d -u nano_file_mc.root, and then if needed adjust the plot range using some human common sense."
What needs to be changed?

@gpetruc-bot
Copy link

@gpetruc-bot
Copy link

Please update PhysicsTools/NanoAOD/python/nanoDQM_cfi.py: take this patch or run prepareDQM.py -d -u nano_file_mc.root, and then if needed adjust the plot range using some human common sense.

Copy link

@gpetruc-bot gpetruc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic test report for 1105370

Code integration

Code checks not run for this PR (no source files modified)

Please update PhysicsTools/NanoAOD/python/nanoDQM_cfi.py: take this patch or run prepareDQM.py -d -u nano_file_mc.root, and then if needed adjust the plot range using some human common sense.

Tests

  • Long test data102X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test data80X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test data80Xhip (3000 events): passed, with differences; dqm plots: all, diff
  • Long test data94X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test data94X2016 (10000 events): passed, with differences; dqm plots: all, diff
  • Long test data94Xv2 (10000 events): passed, with differences; dqm plots: all, diff
  • Long test mc102X (9000 events): passed, with differences; dqm plots: all, diff
  • Long test mc80X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test mc94X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test mc94X2016 (9000 events): passed, with differences; dqm plots: all, diff
  • Long test mc94Xv2 (9000 events): passed, with differences; dqm plots: all, diff
  • Test mc_94Xv2: passed
  • Test mc_102X: passed
  • Test data_94X: passed
  • Test data_102X: passed

Disk size report

Sample kb/event ref kb/event diff
TTbar MC 102X 1.833 1.831 0.002 ( +0.1% )
TTbar MC 94Xv1 1.926 1.924 0.002 ( +0.1% )
TTbar MC 94Xv2 1.959 1.956 0.003 ( +0.2% )
TTbar MC 94X2016 1.747 1.744 0.002 ( +0.1% )
TTbar MC 80X 1.903 1.902 0.001 ( +0.0% )
Data 102X 0.971 0.962 0.009 ( +0.9% )
Data 94Xv1 0.918 0.914 0.004 ( +0.4% )
Data 80X 0.794 0.793 0.001 ( +0.1% )
Data 80X, Mu Run2016E 0.776 0.775 0.001 ( +0.1% )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants