Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port recent pull requests to master #406

Merged
merged 10 commits into from Oct 1, 2019
Merged

Conversation

peruzzim
Copy link

@peruzzim peruzzim commented Oct 1, 2019

@gpetruc-bot
Copy link

Copy link

@gpetruc-bot gpetruc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic test report for 1124766

Tests

@gpetruc-bot
Copy link

@gpetruc-bot
Copy link

Please update PhysicsTools/NanoAOD/python/nanoDQM_cfi.py: take this patch or run prepareDQM.py -d -u nano_file_mc.root, and then if needed adjust the plot range using some human common sense.

@gpetruc-bot
Copy link

Copy link

@gpetruc-bot gpetruc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic test report for 1125655

Tests

@gpetruc-bot
Copy link

@gpetruc-bot
Copy link

@gpetruc-bot
Copy link

Please update PhysicsTools/NanoAOD/python/nanoDQM_cfi.py: take this patch or run prepareDQM.py -d -u nano_file_mc.root, and then if needed adjust the plot range using some human common sense.

Copy link

@gpetruc-bot gpetruc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic test report for 1125803

Code integration

Code checks passed for this PR

Please update PhysicsTools/NanoAOD/python/nanoDQM_cfi.py: take this patch or run prepareDQM.py -d -u nano_file_mc.root, and then if needed adjust the plot range using some human common sense.

Tests

  • Long test data102X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test data106X (9000 events): passed, with differences; dqm plots: all, diff
  • Long test mc106X (9000 events): passed, with differences; dqm plots: all, diff
  • Long test mc80X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test mc94X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test mc94X2016 (9000 events): passed, with differences; dqm plots: all, diff
  • Long test mc94Xv2 (9000 events): passed, with differences; dqm plots: all, diff
  • Test mc_94Xv2: passed
  • Test mc_102X: passed
  • Test data_94X: passed
  • Test data_102X: passed

Copy link

@gpetruc-bot gpetruc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic test report for 1125803

Code integration

Code checks passed for this PR

Please update PhysicsTools/NanoAOD/python/nanoDQM_cfi.py: take this patch or run prepareDQM.py -d -u nano_file_mc.root, and then if needed adjust the plot range using some human common sense.

Tests

  • Long test data102X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test data106X (9000 events): passed, with differences; dqm plots: all, diff
  • Long test data80X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test data80Xhip (3000 events): passed, with differences; dqm plots: all, diff
  • Long test data94X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test data94X2016 (10000 events): passed, with differences; dqm plots: all, diff
  • Long test data94Xv2 (10000 events): passed, with differences; dqm plots: all, diff
  • Long test mc102X (9000 events): passed, with differences; dqm plots: all, diff
  • Long test mc106X (9000 events): passed, with differences; dqm plots: all, diff
  • Long test mc80X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test mc94X (10000 events): passed, with differences; dqm plots: all, diff
  • Long test mc94X2016 (9000 events): passed, with differences; dqm plots: all, diff
  • Long test mc94Xv2 (9000 events): passed, with differences; dqm plots: all, diff
  • Test mc_94Xv2: passed
  • Test mc_102X: passed
  • Test data_94X: passed
  • Test data_102X: passed

Disk size report

Sample kb/event ref kb/event diff
TTbar MC 102X 1.850 1.831 0.019 ( +1.0% )
TTbar MC 94Xv1 1.943 1.924 0.019 ( +1.0% )
TTbar MC 94Xv2 1.974 1.956 0.018 ( +0.9% )
TTbar MC 94X2016 1.764 1.745 0.018 ( +1.1% )
TTbar MC 80X 1.896 1.902 -0.006 ( -0.3% )
Data 102X 0.978 0.963 0.016 ( +1.6% )
Data 94Xv1 0.927 0.913 0.014 ( +1.5% )
Data 80X 0.795 0.793 0.001 ( +0.2% )
Data 80X, Mu Run2016E 0.776 0.774 0.001 ( +0.2% )

@peruzzim peruzzim merged commit 9e97a8f into master-cmsswmaster Oct 1, 2019
@peruzzim peruzzim deleted the port_1oct19_110X branch October 1, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants