make clusterizer kernels independent of grid size #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinInn
commented
Nov 30, 2020
| @@ -19,105 +19,106 @@ namespace gpuClustering { | |||
| uint32_t const* __restrict__ moduleId, // module id of each module | |||
| int32_t* __restrict__ clusterId, // modified: cluster id of each pixel | |||
| uint32_t numElements) { | |||
| if (blockIdx.x >= moduleStart[0]) | |||
There was a problem hiding this comment.
very sorry. code-format has made the few (trivial) changes completely swamped by the new indentation
There was a problem hiding this comment.
No problem - hiding the whitespace changes in git (diff -w) or in GitHub (gear icon --> Hide whitespace changes) alleviates the issue.
Validation summaryReference release CMSSW_11_2_0_pre10 at 6c149b2 Validation plots/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW
/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW
Validation plots (CPU vs GPU)/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW
/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW
Throughput plots/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53
logs and
|
|
No impact on physics or throughput. |
fwyzard
pushed a commit
that referenced
this pull request
Dec 1, 2020
fwyzard
pushed a commit
that referenced
this pull request
Dec 25, 2020
fwyzard
pushed a commit
that referenced
this pull request
Dec 29, 2020
fwyzard
pushed a commit
that referenced
this pull request
Dec 29, 2020
fwyzard
pushed a commit
that referenced
this pull request
Dec 29, 2020
fwyzard
pushed a commit
that referenced
this pull request
Dec 29, 2020
makortel
added a commit
to makortel/pixeltrack-standalone
that referenced
this pull request
Dec 29, 2020
makortel
added a commit
to makortel/pixeltrack-standalone
that referenced
this pull request
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #564 and #586