Simplify cudacompat layer to use a 1-dimensional grid #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the possibility of changing the grid size used by the
cms::cudacompat layer, and make it a constant equal to {1, 1, 1}.
This avoids a thread-related problem caused by TBB using worker threads
where the grid size had not been initialised.
The kernel for pixel clustering need to be rewritten to support a
one-dimensional grid to run on the CPU.
Currently they are only used on the GPU in the Patatrack workflows, but
they are exercised on the CPU by the gpuClustering_t tests; those tests
have been commented out until the kernels can be updated.
Validation summaryReference release CMSSW_11_2_0_pre10 at 6c149b2 Validation plots/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW
/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW
Validation plots (CPU vs GPU)/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW
/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW
Throughput plots/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53
logs and
|
|
Should fix #564 |
|
if compiles and run the code is ok with me. |
VinInn
approved these changes
Nov 30, 2020
RecoPixelVertexing/PixelVertexFinding/plugins/gpuVertexFinderImpl.h
Outdated
Show resolved
Hide resolved
fwyzard
commented
Nov 30, 2020
RecoPixelVertexing/PixelVertexFinding/plugins/gpuVertexFinderImpl.h
Outdated
Show resolved
Hide resolved
makortel
reviewed
Nov 30, 2020
Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>
|
All crashes in the CPU workflows are indeed fixed. No changes to the physics performance or throughput, as expected. |
fwyzard
pushed a commit
that referenced
this pull request
Dec 25, 2020
Remove the possibility of changing the grid size used by the
cms::cudacompat layer, and make it a constant equal to {1, 1, 1}.
This avoids a thread-related problem caused by TBB using worker threads
where the grid size had not been initialised.
The kernel for pixel clustering need to be rewritten to support a
one-dimensional grid to run on the CPU.
Currently they are only used on the GPU in the Patatrack workflows, but
they are exercised on the CPU by the gpuClustering_t tests; those tests
have been commented out until the kernels can be updated.
fwyzard
added a commit
that referenced
this pull request
Dec 26, 2020
Remove the possibility of changing the grid size used by the
cms::cudacompat layer, and make it a constant equal to {1, 1, 1}.
This avoids a thread-related problem caused by TBB using worker threads
where the grid size had not been initialised.
The kernel for pixel clustering need to be rewritten to support a
one-dimensional grid to run on the CPU.
Currently they are only used on the GPU in the Patatrack workflows, but
they are exercised on the CPU by the gpuClustering_t tests; those tests
have been commented out until the kernels can be updated.
fwyzard
pushed a commit
that referenced
this pull request
Dec 29, 2020
Remove the possibility of changing the grid size used by the
cms::cudacompat layer, and make it a constant equal to {1, 1, 1}.
This avoids a thread-related problem caused by TBB using worker threads
where the grid size had not been initialised.
The kernel for pixel clustering need to be rewritten to support a
one-dimensional grid to run on the CPU.
Currently they are only used on the GPU in the Patatrack workflows, but
they are exercised on the CPU by the gpuClustering_t tests; those tests
have been commented out until the kernels can be updated.
fwyzard
pushed a commit
that referenced
this pull request
Dec 29, 2020
Remove the possibility of changing the grid size used by the
cms::cudacompat layer, and make it a constant equal to {1, 1, 1}.
This avoids a thread-related problem caused by TBB using worker threads
where the grid size had not been initialised.
The kernel for pixel clustering need to be rewritten to support a
one-dimensional grid to run on the CPU.
Currently they are only used on the GPU in the Patatrack workflows, but
they are exercised on the CPU by the gpuClustering_t tests; those tests
have been commented out until the kernels can be updated.
fwyzard
added a commit
that referenced
this pull request
Dec 29, 2020
Remove the possibility of changing the grid size used by the
cms::cudacompat layer, and make it a constant equal to {1, 1, 1}.
This avoids a thread-related problem caused by TBB using worker threads
where the grid size had not been initialised.
The kernel for pixel clustering need to be rewritten to support a
one-dimensional grid to run on the CPU.
Currently they are only used on the GPU in the Patatrack workflows, but
they are exercised on the CPU by the gpuClustering_t tests; those tests
have been commented out until the kernels can be updated.
fwyzard
added a commit
that referenced
this pull request
Dec 29, 2020
Remove the possibility of changing the grid size used by the
cms::cudacompat layer, and make it a constant equal to {1, 1, 1}.
This avoids a thread-related problem caused by TBB using worker threads
where the grid size had not been initialised.
The kernel for pixel clustering need to be rewritten to support a
one-dimensional grid to run on the CPU.
Currently they are only used on the GPU in the Patatrack workflows, but
they are exercised on the CPU by the gpuClustering_t tests; those tests
have been commented out until the kernels can be updated.
fwyzard
added a commit
that referenced
this pull request
Dec 29, 2020
Remove the possibility of changing the grid size used by the
cms::cudacompat layer, and make it a constant equal to {1, 1, 1}.
This avoids a thread-related problem caused by TBB using worker threads
where the grid size had not been initialised.
The kernel for pixel clustering need to be rewritten to support a
one-dimensional grid to run on the CPU.
Currently they are only used on the GPU in the Patatrack workflows, but
they are exercised on the CPU by the gpuClustering_t tests; those tests
have been commented out until the kernels can be updated.
makortel
added a commit
to makortel/pixeltrack-standalone
that referenced
this pull request
Dec 29, 2020
makortel
added a commit
to makortel/pixeltrack-standalone
that referenced
this pull request
Dec 29, 2020
fwyzard
pushed a commit
that referenced
this pull request
Jan 13, 2021
Remove the possibility of changing the grid size used by the
cms::cudacompat layer, and make it a constant equal to {1, 1, 1}.
This avoids a thread-related problem caused by TBB using worker threads
where the grid size had not been initialised.
The kernel for pixel clustering need to be rewritten to support a
one-dimensional grid to run on the CPU.
Currently they are only used on the GPU in the Patatrack workflows, but
they are exercised on the CPU by the gpuClustering_t tests; those tests
have been commented out until the kernels can be updated.
fwyzard
added a commit
that referenced
this pull request
Jan 15, 2021
Remove the possibility of changing the grid size used by the
cms::cudacompat layer, and make it a constant equal to {1, 1, 1}.
This avoids a thread-related problem caused by TBB using worker threads
where the grid size had not been initialised.
The kernel for pixel clustering need to be rewritten to support a
one-dimensional grid to run on the CPU.
Currently they are only used on the GPU in the Patatrack workflows, but
they are exercised on the CPU by the gpuClustering_t tests; those tests
have been commented out until the kernels can be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the possibility of changing the grid size used by the
cms::cudacompatlayer, and make it a constant equal to{1, 1, 1}.This avoids a thread-related problem caused by TBB using worker threads where the grid size had not been initialised.
The kernel for pixel clustering need to be rewritten to support a one-dimensional grid to run on the CPU.
Currently they are only used on the GPU in the Patatrack workflows, but they are exercised on the CPU by the
gpuClustering_ttests; those tests have been commented out until the kernels can be updated.