Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reco comparisons: add DNN ID plots for electrons and photons #1659

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Nov 4, 2021

To add supporting plots for ID variables added in cms-sw/cmssw#35403

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2021

A new Pull Request was created by @slava77 (Slava Krutelyov) for branch master.

@cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Nov 4, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a63fc0/20259/summary.html
COMMIT: 880a2d5
CMSSW: CMSSW_12_2_X_2021-11-04-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/1659/20259/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901890
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901868
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor Author

slava77 commented Nov 4, 2021

the logs look OK (reconfirming already what I've seen in local tests).

It may be more practical to merge this soon after jenkins moves to CMSSW_12_2_X_2021-11-04-2300, which has cms-sw/cmssw#35984; prior to that this PR will show occasional random differences in two variables that are being read from uninitialized memory (out of range)

@smuzaffar
Copy link
Contributor

+external
Thanks @slava77

@smuzaffar smuzaffar merged commit 8a8ca28 into cms-sw:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants