New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing memory bug in GsfElectronProducer #35984
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35984/26414
|
A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master. It involves the following packages:
@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
please test for CMSSW_12_2_ASAN_X |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0df7e7/20247/summary.html Comparison SummarySummary:
|
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0df7e7/20248/summary.html Comparison SummarySummary:
|
fix memory bug in DNN-based ID (packport of #35984)
PR description:
This PR aims to fix a memory bug found by AddressSanitizer and reported in the github issue #35760. The bug was introduced in the context of transitioning PF Egamma ID from BDT to DNN (#35403).
This PR is purely technical in nature; no change in physics is expected.
PR validation:
From
CMSSW_12_2_ASAN_X_2021-11-01-2300
, ranrunTheMatrix.py -l 11634.7
. It crashed withAddressSanitizer: heap-buffer-overflow
. Then merged this branch, recompiled and ran the same workflow again. No crash happened.This PR is not a backport.
Backport not needed.