-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump xrootd to rc2 and add python support #2975
bump xrootd to rc2 and add python support #2975
Conversation
…per (#18102)" This reverts commit 086343f.
There should be the final 4.6 tagged soonish. It will contain GCC 7 cleanups except in old XrdClient. It will only be disabled right before releasing 4.6. They do not intend to fix it for GCC 7. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_9_1_X/gcc530. @cmsbuild, @smuzaffar, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks. |
xrootd.spec
Outdated
@@ -1,6 +1,6 @@ | |||
### RPM external xrootd 4.5.0 | |||
## INITENV +PATH LD_LIBRARY_PATH %i/lib64 | |||
%define tag 6a5db61a4ef13d1e79da71af47fbb8a660cf8aac | |||
%define tag af6aebbbbe7da7fd89f3698c1e485a79a5990037 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this commit needed? Looks to be useless here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was following the commit history from the gcc7 branch.. (unneeded I guess)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see such commit in the history: https://github.com/cms-sw/cmsdist/commits/IB/CMSSW_9_1_X/gcc700/xrootd.spec
Ah- then I first reverted the commit that added the previously proposed fix to the gcc530 branch to put the branches back in sync.
David
On 21 Apr 2017, at 19:09, davidlt <notifications@github.com<mailto:notifications@github.com>> wrote:
@davidlt commented on this pull request.
________________________________
In xrootd.spec<#2975 (comment)>:
@@ -1,6 +1,6 @@
### RPM external xrootd 4.5.0
## INITENV +PATH LD_LIBRARY_PATH %i/lib64
-%define tag 6a5db61a4ef13d1e79da71af47fbb8a660cf8aac
+%define tag af6aebbbbe7da7fd89f3698c1e485a79a5990037
I don't see such commit in the history: https://github.com/cms-sw/cmsdist/commits/IB/CMSSW_9_1_X/gcc700/xrootd.spec
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#2975 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzyw6ed3x1lOOExbYadMzH3e7wNnUodks5ryOKQgaJpZM4NEhnQ>.
|
Comparison job queued. |
Comparison is ready Comparison Summary:
|
this time cherry-picking.
the python changes are not tested so believing davida's suggestions..