pick up root commits needed for modules testing

[davidlange6]

and include cxxmodules.mk changes from @vgvassilev

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_11_1_X/rootmodule.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[davidlange6]

whoops - I think I have more commits to pick up

[cmsbuild]

Pull request #5558 was updated.

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4711/console Started: 2020/02/17 19:07

[cmsbuild]

-1

Tested at: 3c2e1bd

CMSSW: CMSSW_11_1_CXXMODULE_X_2020-02-13-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b8eb4/4711/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found compilation error when building:

In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_CXXMODULE_X_2020-02-13-2300/src/DataFormats/ParticleFlowReco/interface/RecoPFClusterRefCandidate.h:6:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_CXXMODULE_X_2020-02-13-2300/src/DataFormats/ParticleFlowReco/interface/PFCluster.h:12:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_CXXMODULE_X_2020-02-13-2300/src/DataFormats/ParticleFlowReco/interface/PFRecHit.h:19:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_CXXMODULE_X_2020-02-13-2300/src/Geometry/CaloGeometry/interface/CaloCellGeometry.h:7:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/clhep/2.4.0.0-nmpfii/include/CLHEP/Geometry/Point3D.h:19:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/clhep/2.4.0.0-nmpfii/include/CLHEP/Vector/ThreeVector.h:41:7: error: redefinition of 'Hep3Vector'
class Hep3Vector {
      ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/clhep/2.4.0.0-nmpfii/include/CLHEP/Vector/LorentzVector.h:30:10: note: '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/clhep/2.4.0.0-nmpfii/include/CLHEP/Vector/ThreeVector.h' included multiple times, additional include site here
#include "CLHEP/Vector/ThreeVector.h"
         ^


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[davidlange6]

I've tested a full build on the side which works (at least compiles).