[cxxmodules] Workaround missing CLHEP modulemap. #28925
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28925/13724
|
|
A new Pull Request was created by @vgvassilev (Vassil Vassilev) for master. It involves the following packages: DataFormats/BTauReco @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Please test |
|
The tests are being triggered in jenkins. |
Currently all contents are pasted N times in the including modules due to the lack of a CLHEP module for the external to cmssw package. This walks on a very fragile path in the compiler (and roocling) as it needs to figure out while parsing the header content that a module already contained the definitions being parsed. This patch avoids an issue where rootcling thinks that CLHEP/.../ThreeVector.h is included multiple times. We essentially tell the compiler to open the definition from a module rather than parsing.
|
-1 Tested at: c41612e CMSSW: CMSSW_11_1_X_2020-02-11-1100 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build HeaderConsistency
I found compilation error when building: >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-11-1100/src/DataFormats/BTauReco/src/TemplatedSoftLeptonTagInfo.cc
>> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-11-1100/src/DataFormats/BTauReco/src/VertexTypes.cc
>> Building LCG reflex dict from header file src/DataFormats/BTauReco/src/classes.h
>> Compiling LCG dictionary: tmp/slc7_amd64_gcc820/src/DataFormats/BTauReco/src/DataFormatsBTauReco/a/DataFormatsBTauReco_xr.cc
In file included from DataFormatsBTauReco/a/DataFormatsBTauReco_xr.cc:47:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-11-1100/src/DataFormats/BTauReco/src/classes.h:18:18: error: missing binary operator before token "("
#if __has_feature(modules)
^
gmake: *** [tmp/slc7_amd64_gcc820/src/DataFormats/BTauReco/src/DataFormatsBTauReco/a/DataFormatsBTauReco_xr.cc.o] Error 1
>> Building shared library tmp/slc7_amd64_gcc820/src/DataFormats/BTauReco/src/DataFormatsBTauReco/libDataFormatsBTauReco.so
c++: error: tmp/slc7_amd64_gcc820/src/DataFormats/BTauReco/src/DataFormatsBTauReco/a/DataFormatsBTauReco_xr.cc.o: No such file or directory
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
vgvassilev
force-pushed
the
cxxmodules_workaround_clhep
branch
from
c41612e
to
1841a8f
Compare
cmsbuild
added
code-checks-pending
and removed
code-checks-approved
comparison-notrun
tests-rejected
labels
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
In the same manner as in cms-sw#28925 we force the definition of Hep3Vector to be read from the module that contains it rather than parsing it.
In the same manner as in cms-sw#28925 we force the definition of Hep3Vector to be read from the module that contains it rather than parsing it.
|
+1 |
Currently all contents are pasted N times in the including modules due to the lack of a CLHEP module for the external to cmssw package.
This walks on a very fragile path in the compiler (and roocling) as it needs to figure out while parsing the header content that a module already contained the definitions being parsed.
This patch avoids an issue where rootcling thinks that CLHEP/.../ThreeVector.h is included multiple times. We essentially tell the compiler to open the definition from a module rather than parsing.
Part of #15248
cc: @davidlange6, @smuzaffar, @oshadura