ROOT master - integrate with TBB 2021 #6558

mrodozov · 2021-01-18T09:38:31Z

No description provided.

cmsbuild · 2021-01-18T09:38:54Z

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_3_X/rootmaster.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

mrodozov · 2021-01-18T09:39:08Z

please test with #6544

cmsbuild · 2021-01-18T10:24:33Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-623c54/12315/summary.html
COMMIT: 9b83883
CMSSW: CMSSW_11_3_ROOT6_X_2021-01-17-2300/slc7_amd64_gcc900

External Build

I found compilation error when building:

then mv -f ".deps/DefTable.Tpo" ".deps/DefTable.Po"; else rm -f ".deps/DefTable.Tpo"; exit 1; fi
if g++ -DHAVE_CONFIG_H -I. -I. -I../../include/HepPDT -I../../include -I../../include  -I/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/tbb/v2021.1.1-6f94df567e79f364c99ad4d828ddb6b1/include -O -ansi -pedantic -Wall -O2 -std=c++17 -MT HeavyIonUnknownID.o -MD -MP -MF ".deps/HeavyIonUnknownID.Tpo" -c -o HeavyIonUnknownID.o HeavyIonUnknownID.cc; \
then mv -f ".deps/HeavyIonUnknownID.Tpo" ".deps/HeavyIonUnknownID.Po"; else rm -f ".deps/HeavyIonUnknownID.Tpo"; exit 1; fi
In file included from HeavyIonUnknownID.cc:8:
../../include/HepPDT/ParticleDataTable.hh: In member function 'size_t HepPDT::ParticleDataTable::PIDhash::operator()(const HepPDT::ParticleID&) const':
../../include/HepPDT/ParticleDataTable.hh:52:19: error: 'tbb_hasher' is not a member of 'tbb'
52 |       return tbb::tbb_hasher(p.pid());
|                   ^~~~~~~~~~
make[1]: *** [HeavyIonUnknownID.o] Error 1
make[1]: Leaving directory `/build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/external/heppdt/3.04.01-28dfc1d773c4655e6b90d997712c3a61/heppdt-3.04.01/src/HepPDT'
make: *** [all-recursive] Error 1

mrodozov · 2021-01-18T11:01:15Z

please test with #6544, cms-externals/heppdt#1

cmsbuild · 2021-01-18T11:42:31Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-623c54/12317/summary.html
COMMIT: 9b83883
CMSSW: CMSSW_11_3_ROOT6_X_2021-01-17-2300/slc7_amd64_gcc900

External Build

I found compilation error when building:

* The action "build-lcg+root+6.23.01-725b5e05650d8bf8cd995e6f1f38ca75" was not completed successfully because Failed to build root. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.23.01-725b5e05650d8bf8cd995e6f1f38ca75/log. Final lines of the log file:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.23.01-725b5e05650d8bf8cd995e6f1f38ca75/root-6.23.01/core/imt/inc/ROOT/RTaskArena.hxx:40:28: note: forward declaration of 'using task_arena = class tbb::interface7::task_arena' {aka 'class tbb::interface7::task_arena'}
40 | namespace interface7{class task_arena;}
|                            ^~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.23.01-725b5e05650d8bf8cd995e6f1f38ca75/root-6.23.01/core/imt/src/TThreadExecutor.cxx: In member function 'float ROOT::TThreadExecutor::ParallelReduce(const std::vector&, const std::function&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.23.01-725b5e05650d8bf8cd995e6f1f38ca75/root-6.23.01/core/imt/src/TThreadExecutor.cxx:204:30: error: invalid use of incomplete type 'using task_arena = class tbb::interface7::task_arena' {aka 'class tbb::interface7::task_arena'}
204 |    return fTaskArenaW->Access().execute([&] { return ROOT::Internal::ParallelReduceHelper(objs, redfunc); });
|           ~~~~~~~~~~~~~~~~~~~^~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.23.01-725b5e05650d8bf8cd995e6f1f38ca75/root-6.23.01/core/imt/inc/ROOT/TThreadExecutor.hxx:27,
from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.23.01-725b5e05650d8bf8cd995e6f1f38ca75/root-6.23.01/core/imt/src/TThreadExecutor.cxx:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.23.01-725b5e05650d8bf8cd995e6f1f38ca75/root-6.23.01/core/imt/inc/ROOT/RTaskArena.hxx:40:28: note: forward declaration of 'using task_arena = class tbb::interface7::task_arena' {aka 'class tbb::interface7::task_arena'}

mrodozov · 2021-01-18T21:39:05Z

please test with #6544, cms-externals/heppdt#1

cmsbuild · 2021-01-18T21:39:12Z

Pull request #6558 was updated.

cmsbuild · 2021-01-18T22:21:16Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-623c54/12336/summary.html
COMMIT: d53dfdc
CMSSW: CMSSW_11_3_ROOT6_X_2021-01-17-2300/slc7_amd64_gcc900

External Build

I found compilation error when building:

* The action "build-lcg+root+6.23.01-e1530c6fc81faf683a6495ee4a121a42" was not completed successfully because Failed to build root. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.23.01-e1530c6fc81faf683a6495ee4a121a42/log. Final lines of the log file:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.23.01-e1530c6fc81faf683a6495ee4a121a42/root-6.23.01/core/imt/inc/ROOT/RTaskArena.hxx:46:28: note: forward declaration of 'using task_arena = class tbb::interface7::task_arena' {aka 'class tbb::interface7::task_arena'}
46 | namespace interface7{class task_arena;}
|                            ^~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.23.01-e1530c6fc81faf683a6495ee4a121a42/root-6.23.01/core/imt/src/TThreadExecutor.cxx: In member function 'float ROOT::TThreadExecutor::ParallelReduce(const std::vector&, const std::function&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.23.01-e1530c6fc81faf683a6495ee4a121a42/root-6.23.01/core/imt/src/TThreadExecutor.cxx:204:30: error: invalid use of incomplete type 'using task_arena = class tbb::interface7::task_arena' {aka 'class tbb::interface7::task_arena'}
204 |    return fTaskArenaW->Access().execute([&] { return ROOT::Internal::ParallelReduceHelper(objs, redfunc); });
|           ~~~~~~~~~~~~~~~~~~~^~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.23.01-e1530c6fc81faf683a6495ee4a121a42/root-6.23.01/core/imt/inc/ROOT/TThreadExecutor.hxx:27,
from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.23.01-e1530c6fc81faf683a6495ee4a121a42/root-6.23.01/core/imt/src/TThreadExecutor.cxx:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.23.01-e1530c6fc81faf683a6495ee4a121a42/root-6.23.01/core/imt/inc/ROOT/RTaskArena.hxx:46:28: note: forward declaration of 'using task_arena = class tbb::interface7::task_arena' {aka 'class tbb::interface7::task_arena'}

this is building with new tbb root-project/root#7062 ROOT needed additional adjustments for ROOT master to build

cmsbuild · 2021-01-20T09:26:07Z

Pull request #6558 was updated.

mrodozov · 2021-01-20T09:26:59Z

checking cupla and alpaka before running the test again

dd4hep.spec

cmsbuild · 2021-01-20T09:36:39Z

Pull request #6558 was updated.

mrodozov · 2021-01-20T09:38:17Z

please test with #6544, cms-externals/heppdt#1
heppdt#1 was merged but not changed in cmsdist, we still need it. alpaka and cupla built with new tbb

mrodozov · 2021-01-20T12:31:59Z

:/
/cvmfs/cms-ib.cern.ch/nweek-02664/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_11_3_ROOT6_X_2021-01-19-2300/lib/slc7_amd64_gcc900/libFWCorePluginManager.so: undefined reference to tbb::internal::concurrent_vector_base_v3::internal_capacity() const'
it appears we'll have to adjust cmssw as well

cmsbuild · 2021-01-20T13:51:12Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-623c54/12374/summary.html
COMMIT: a82dd9e
CMSSW: CMSSW_11_3_ROOT6_X_2021-01-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6558/12374/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2021-01-19-2300/src/FWCore/Concurrency/src/ThreadsController.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2021-01-19-2300/src/FWCore/Concurrency/src/WaitingTaskList.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2021-01-19-2300/src/FWCore/Concurrency/src/WaitingTaskWithArenaHolder.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2021-01-19-2300/src/FWCore/Concurrency/src/setNThreads.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2021-01-19-2300/src/FWCore/Concurrency/src/SerialTaskQueue.cc:17:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2021-01-19-2300/src/FWCore/Concurrency/interface/SerialTaskQueue.h:134:39: error: expected class-name before '{' token
  134 |     class TaskBase : public tbb::task {
      |                                       ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2021-01-19-2300/src/FWCore/Concurrency/interface/SerialTaskQueue.h:166:22: error: 'tbb::empty_task' has not been declared
  166 |     void pushAndWait(tbb::empty_task* iWait, TaskBase*);
      |                      ^~~

makortel · 2021-01-20T14:10:00Z

it appears we'll have to adjust cmssw as well

It looks to me that we need to wait for @Dr15Jones to finish the migration from tbb::task to tbb::task_group.

cmsbuild · 2021-01-25T21:40:15Z

Pull request #6558 was updated.

mrodozov · 2021-01-25T21:40:32Z

please test with #6544

cmsbuild · 2021-01-26T01:57:34Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-623c54/12530/summary.html
COMMIT: e0f503d
CMSSW: CMSSW_11_3_ROOT6_X_2021-01-24-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/6558/12530/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2021-01-24-2300/src/FWCore/Concurrency/src/ThreadsController.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2021-01-24-2300/src/FWCore/Concurrency/src/WaitingTaskList.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2021-01-24-2300/src/FWCore/Concurrency/src/WaitingTaskWithArenaHolder.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2021-01-24-2300/src/FWCore/Concurrency/src/setNThreads.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2021-01-24-2300/src/FWCore/Concurrency/src/SerialTaskQueue.cc:17:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2021-01-24-2300/src/FWCore/Concurrency/interface/SerialTaskQueue.h:134:39: error: expected class-name before '{' token
  134 |     class TaskBase : public tbb::task {
      |                                       ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2021-01-24-2300/src/FWCore/Concurrency/interface/SerialTaskQueue.h:166:22: error: 'tbb::empty_task' has not been declared
  166 |     void pushAndWait(tbb::empty_task* iWait, TaskBase*);
      |                      ^~~

Dr15Jones · 2021-01-26T14:35:02Z

The tbb::task API was deprecated and may have been fully removed in the newest version of oneTBB. I'm in the process of removing CMSSW's useage of tbb::task but it is still very much a work in progress.

mrodozov · 2021-01-26T15:04:04Z

no worries,
I'm testing weekly ROOT changes in both 622 and master for integration purposes.
We can survive some time without integrating lastest ROOTs :)

mrodozov · 2021-02-05T14:22:17Z

closing this one we'll use #6612 for DD4 testing

mrodozov · 2021-02-05T14:27:10Z

see #6622 root master (externals) integration.

Updated root to tip of branch master

9b83883

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels Jan 18, 2021

cmsbuild added tests-started and removed tests-pending labels Jan 18, 2021

cmsbuild added tests-rejected and removed tests-started labels Jan 18, 2021

cmsbuild added tests-started and removed tests-rejected labels Jan 18, 2021

cmsbuild added tests-rejected and removed tests-started labels Jan 18, 2021

add TBB interface adjustment from ROOT

d53dfdc

cmsbuild added tests-started and removed tests-rejected labels Jan 18, 2021

cmsbuild added tests-rejected and removed tests-started labels Jan 18, 2021

mrodozov changed the title ~~Updated root to tip of branch master~~ TBB 2021 - integrate with ROOT master Jan 19, 2021

mrodozov changed the title ~~TBB 2021 - integrate with ROOT master~~ ROOT master - integrate with TBB 2021 Jan 19, 2021

pick another ROOT PR for integration with tbb 2021

4ed3204

this is building with new tbb root-project/root#7062 ROOT needed additional adjustments for ROOT master to build

cmsbuild removed the tests-rejected label Jan 19, 2021

smuzaffar reviewed Jan 20, 2021

View reviewed changes

dd4hep.spec Outdated Show resolved Hide resolved

remove path to tbb cmake files since it's not used

a82dd9e

cmsbuild added tests-started and removed tests-pending labels Jan 20, 2021

cmsbuild added tests-rejected and removed tests-started labels Jan 20, 2021

get latest from master to test

e0f503d

cmsbuild added tests-pending and removed tests-rejected labels Jan 25, 2021

cmsbuild added tests-started tests-rejected and removed tests-pending tests-started labels Jan 25, 2021

mrodozov closed this Feb 5, 2021

cmsbuild added the requires-external label Feb 5, 2021

mrodozov deleted the root-update-master-20210118 branch February 5, 2021 14:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ROOT master - integrate with TBB 2021 #6558

ROOT master - integrate with TBB 2021 #6558

mrodozov commented Jan 18, 2021

cmsbuild commented Jan 18, 2021

mrodozov commented Jan 18, 2021

cmsbuild commented Jan 18, 2021

mrodozov commented Jan 18, 2021

cmsbuild commented Jan 18, 2021

mrodozov commented Jan 18, 2021

cmsbuild commented Jan 18, 2021

cmsbuild commented Jan 18, 2021

cmsbuild commented Jan 20, 2021

mrodozov commented Jan 20, 2021

cmsbuild commented Jan 20, 2021

mrodozov commented Jan 20, 2021

mrodozov commented Jan 20, 2021 •

edited

Loading

cmsbuild commented Jan 20, 2021

makortel commented Jan 20, 2021

cmsbuild commented Jan 25, 2021

mrodozov commented Jan 25, 2021

cmsbuild commented Jan 26, 2021

Dr15Jones commented Jan 26, 2021

mrodozov commented Jan 26, 2021

mrodozov commented Feb 5, 2021

mrodozov commented Feb 5, 2021

ROOT master - integrate with TBB 2021 #6558

ROOT master - integrate with TBB 2021 #6558

Conversation

mrodozov commented Jan 18, 2021

cmsbuild commented Jan 18, 2021

mrodozov commented Jan 18, 2021

cmsbuild commented Jan 18, 2021

External Build

mrodozov commented Jan 18, 2021

cmsbuild commented Jan 18, 2021

External Build

mrodozov commented Jan 18, 2021

cmsbuild commented Jan 18, 2021

cmsbuild commented Jan 18, 2021

External Build

cmsbuild commented Jan 20, 2021

mrodozov commented Jan 20, 2021

cmsbuild commented Jan 20, 2021

mrodozov commented Jan 20, 2021

mrodozov commented Jan 20, 2021 • edited Loading

cmsbuild commented Jan 20, 2021

Build

makortel commented Jan 20, 2021

cmsbuild commented Jan 25, 2021

mrodozov commented Jan 25, 2021

cmsbuild commented Jan 26, 2021

Build

Dr15Jones commented Jan 26, 2021

mrodozov commented Jan 26, 2021

mrodozov commented Feb 5, 2021

mrodozov commented Feb 5, 2021

mrodozov commented Jan 20, 2021 •

edited

Loading