Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated root to tip of branch master - test integration with TBB.21 and DD4.15 #6622

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Feb 5, 2021

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2021

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_3_X/rootmaster.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

mrodozov commented Feb 5, 2021

test parameters:

@mrodozov
Copy link
Contributor Author

mrodozov commented Feb 5, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2021

-1

Failed Tests: Build HeaderConsistency ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b5b88/12735/summary.html
COMMIT: 3113d27
CMSSW: CMSSW_11_3_X_2021-02-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6622/12735/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-05-1100/src/FWCore/Concurrency/src/WaitingTaskList.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-05-1100/src/FWCore/Concurrency/src/WaitingTaskWithArenaHolder.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-05-1100/src/FWCore/Concurrency/src/setNThreads.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-05-1100/src/FWCore/Concurrency/interface/WaitingTaskList.h:77,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-05-1100/src/FWCore/Concurrency/src/WaitingTaskList.cc:21:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-05-1100/src/FWCore/Concurrency/interface/WaitingTask.h:36:40: error: expected class-name before '{' token
   36 |   class WaitingTask : public tbb::task {
      |                                        ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-05-1100/src/FWCore/Concurrency/interface/WaitingTask.h:44:5: error: 'edm::WaitingTask::~WaitingTask()' marked 'override', but does not override
   44 |     ~WaitingTask() override { delete m_ptr.load(); };
      |     ^


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-05-1100/src/Alignment/APEEstimation/plugins/ApeTreeCreateDefault.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-05-1100/src/Alignment/APEEstimation/plugins/ApeEstimator.cc:28:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-05-1100/src/FWCore/Framework/interface/one/EDAnalyzer.h:24:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-05-1100/src/FWCore/Framework/interface/one/analyzerAbilityToImplementor.h:26:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-05-1100/src/FWCore/Framework/interface/one/implementors.h:28:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-05-1100/src/FWCore/Concurrency/interface/SerialTaskQueue.h:134:34: error: expected class name
    class TaskBase : public tbb::task {
                                 ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-02-05-1100/src/FWCore/Concurrency/interface/SerialTaskQueue.h:153:27: error: only virtual member functions can be marked 'override'
      TaskBase* execute() override;
                          ^~~~~~~~


@mrodozov mrodozov closed this Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants