Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LLVM to version 12.0.1 #7258

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 31, 2021

No description provided.

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 31, 2021

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 31, 2021

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_12_1_X/master.

@smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor

mrodozov commented Aug 31, 2021

there is 13 already, should we get it given numba and llvmlite are relatively simple to adjust ?

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 31, 2021

no idea.. they make new releases too quickly !

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-425721/18158/summary.html
COMMIT: 81d24c2
CMSSW: CMSSW_12_1_X_2021-08-31-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7258/18158/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000404
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000382
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

please test for CMSSW_12_1_CLANG_X

@smuzaffar
Copy link
Contributor

looks good though, I ran clang-tidy and format on full cmssw. For clang-tidy there are no changes but clang format suggests changes for few extra files

DataFormats/SiStripCluster/interface/SiStripClusterfwd.h
SimG4CMS/HGCalTestBeam/src/HGCalTB16SD01.cc
SimG4CMS/ShowerLibraryProducer/interface/FiberSD.h
SimG4CMS/ShowerLibraryProducer/interface/HFChamberSD.h
SimG4CMS/ShowerLibraryProducer/interface/HFWedgeSD.h
SimG4CMS/ShowerLibraryProducer/src/FiberSD.cc
SimG4CMS/ShowerLibraryProducer/src/HFChamberSD.cc
SimG4CMS/ShowerLibraryProducer/src/HFWedgeSD.cc
DQM/CSCMonitorModule/plugins/CSCDQM_Configuration.h
DataFormats/SiStripCluster/interface/SiStripClusterfwd.h
DetectorDescription/Core/test/DDFilter.cppunit.cc
FWCore/FWLite/bin/storageSizeForBranch.cc
FWCore/Framework/test/statemachine_t.cc
FWCore/Integration/bin/interprocess.cc
FWCore/Integration/bin/interprocess_random.cc
FWCore/PluginManager/bin/dump.cc
Fireworks/Core/src/CmsShowMain.cc
GeneratorInterface/Core/bin/externalGenerator.cc
RecoBTau/JetTagComputer/interface/GenericMVAJetTagComputerWrapper.h
SimG4CMS/HGCalTestBeam/src/HGCalTB16SD01.cc
SimG4CMS/ShowerLibraryProducer/interface/FiberSD.h
SimG4CMS/ShowerLibraryProducer/interface/HFChamberSD.h
SimG4CMS/ShowerLibraryProducer/interface/HFWedgeSD.h
SimG4CMS/ShowerLibraryProducer/src/FiberSD.cc
SimG4CMS/ShowerLibraryProducer/src/HFChamberSD.cc
SimG4CMS/ShowerLibraryProducer/src/HFWedgeSD.cc

@makortel
Copy link
Contributor

makortel commented Sep 1, 2021

clang format suggests changes for few extra files

By quick look the patch looks ok to me. Some of the changes look like those files would not have been formatted before though.

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-425721/18193/summary.html
COMMIT: 81d24c2
CMSSW: CMSSW_12_1_CLANG_X_2021-08-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7258/18193/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-425721/18193/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-425721/18193/git-merge-result

Comparison Summary

Summary:

  • You potentially added 95467 lines to the logs
  • Reco comparison results: 17626 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000404
  • DQMHistoTests: Total failures: 56005
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 2944369
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.008 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 136.793 ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 1 / 38 workflows

@fwyzard fwyzard deleted the IB/CMSSW_12_1_X/master_llvm_12.0.1 branch April 1, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants