Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Change hls4ml emulator extra version to avoid segfault #9065

Conversation

aloeliger
Copy link
Contributor

Taken from #9064

This PR upgrades the version of hls4mlEmulatorExtras to avoid a segfault on failure to load model needed for AXO error handling in cms-sw/cmssw#44054

The new release can be seen here: https://github.com/cms-hls4ml/hls4mlEmulatorExtras/releases/tag/v1.1.2

the only changed introduced is this cms-hls4ml/hls4mlEmulatorExtras#4

A backport will be required to 14_0 for AXO's backport to this same release

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2024

A new Pull Request was created by @aloeliger for branch IB/CMSSW_14_0_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2024

cms-bot internal usage

@aloeliger aloeliger changed the title Change hls4ml emulator extra version to avoid segfault [14_0_X] Change hls4ml emulator extra version to avoid segfault Mar 12, 2024
@aloeliger
Copy link
Contributor Author

Backport of #9064

@aloeliger
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #9065 was updated.

@aloeliger
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bf821/38071/summary.html
COMMIT: 6d48549
CMSSW: CMSSW_14_0_X_2024-03-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9065/38071/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 39 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3342271
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342246
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link

Better to merge together with cms-sw/cmssw#44397

@artlbv
Copy link

artlbv commented Mar 22, 2024

FYI: cms-sw/cmssw#44397 was closed and replaced by cms-sw/cmssw#44511

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#44511

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bf821/38407/summary.html
COMMIT: 6d48549
CMSSW: CMSSW_14_0_X_2024-03-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9065/38407/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 47 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3243082
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3243054
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 163 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link

@cms-sw/l1-l2

Should this PR be included in the next 14_0_X release, too ?

@aloeliger
Copy link
Contributor Author

@cms-sw/l1-l2

Should this PR be included in the next 14_0_X release, too ?

@missirol if possible. It would be good for this to crash out informatively on the off chance.

@antoniovilela
Copy link

+1

@cmsbuild cmsbuild merged commit 513f002 into cms-sw:IB/CMSSW_14_0_X/master Mar 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants