[14_0_0] Backport of #44510 AXOL1TL emulator update for L1 Menu parsing with UTMv12 #44511

artlbv · 2024-03-22T11:26:40Z

PR description:

This is a backport of #44510 needed for the AXOL1TL L1 emulator to be compatible with the new and old UTM grammar for the seed and model selection. The description below is copied from the above PR.

This PR is an amendment of the AXOL1TL emulator PRs: #44054 (original backport: #44397).
Essentially reverting and extending the AXO-only part of this revert: #44466

The main changes are:

As the original PR, this introduces compatibility with the new UTM "grammar" (v12) for the AXO seed, i.e. what is used in the L1Menu_Collisions2024_v1_1_0 (see the AXO seeds in that menu here.
New: Added backward compatibility with the previous UTM "grammar" (pre v12) for the AXO seed, i.e. what is used in the L1Menu_Collisions2024_v1_0_0 (see the AXO seeds in that menu here). Note that UTM v12 supports the old and new AXO condition type.
For this kind of seeds the AXO model is hard-coded to the v3 version as this is currently the baseline.
New: cleaned up the AXO model setting in the L1GlobalProducer/Board code as the model version is not defined globally anymore, but on the seed level.

No additional PRs are needed to test this PR.

PR validation:

I tested this PR in 14_1 (and 14_0) with the following command with the default 1_0_0 L1 menu (old UTM), but also with 1_1_0 (new UTM for AXO) and a menu where I mix both old and new AXO conditions. Note this is inspired by the workflow 141.044_RunJetMET2023D but faster for testing.

Rerunning L1 and HLT with the default L1 Menu 1_0_0:

cmsDriver.py repackuGT_reHLT -s L1REPACK:Full,HLT:@relval2024 --process reHLT --datatier NANOAOD --eventcontent NANOAOD \
-n 100 --era=Run3 \            
--data --conditions=auto:run3_hlt_relval  \
--filein=/store/data/Run2023D/JetMET0/RAW/v1/000/369/978/00000/00b9eba7-c847-465b-a6de-98bceae93613.root

Rerunning L1 and HLT with the 1_0_1 L1 Menu by specifying it via:

--customise=L1Trigger/Configuration/customiseUtils.L1TGlobalMenuXML

In all cases L1 and HLT properly ran. Note though that given the current HLS4ML issues (see #44435), the AXO seeds fire in all events in the current master.
This can be circumvented by adding this to the config (removing the CICADA emulator from the L1 chain):

process.SimL1Emulator.remove(process.simCaloStage2Layer1Summary)

The results are in line with what is expected:

../repackuGT_reHLT_L1_101_L1REPACK_HLT.root
Trigs for 100 events:
DST_PFScouting_AXONominal    100
DST_PFScouting_AXOTight      100
HLT_L1AXOVTight              100
dtype: int64
../repackuGT_reHLT_L1_101_L1REPACK_HLT_noCICADA.root
Trigs for 100 events:
DST_PFScouting_AXONominal    0
DST_PFScouting_AXOTight      0
HLT_L1AXOVTight              0
dtype: int64
../repackuGT_reHLT_def_L1REPACK_HLT.root
Trigs for 100 events:
DST_PFScouting_AXONominal    100
DST_PFScouting_AXOTight      100
HLT_L1AXOVTight              100
dtype: int64
../repackuGT_reHLT_def_L1REPACK_HLT_noCICADA.root
Trigs for 100 events:
DST_PFScouting_AXONominal    2
DST_PFScouting_AXOTight      1
HLT_L1AXOVTight              0

The results for L1 were checked with the L1 menu ntuples and show agreement for using different UTM grammar within the same XML:

141 L1ReEmu
seed                	unp	emu	mism
L1_AXO_Nominal      	0	2	2
L1_AXO_Tight        	0	1	1
L1_AXO_VLoose       	0	11	11
L1_AXO_VLooseNewUTMv3	0	11	11
L1_AXO_VTight       	0	0	0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Original PR: #44510

Reason for backport: add compatibility for the AXOL1TL emulator with the new UTM grammar which is required for proper O2O of the L1 conditions. Needed in CMSSW_14_0_X for the initial data-taking in 2024.

cmsbuild · 2024-03-22T11:27:06Z

A new Pull Request was created by @artlbv for CMSSW_14_0_X.

It involves the following packages:

HLTrigger/Configuration (hlt)
L1Trigger/L1TGlobal (l1)

@mmusich, @epalencia, @aloeliger, @Martin-Grunewald, @cmsbuild can you please review it and eventually sign? Thanks.
@silviodonato, @missirol, @Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

Backported from AXOL1TL emulator update for L1 Menu parsing with UTMv12 #44510

cmsbuild · 2024-03-22T11:27:06Z

cms-bot internal usage

cmsbuild · 2024-03-22T11:44:14Z

Pull request #44511 was updated. @epalencia, @mmusich, @Martin-Grunewald, @aloeliger, @cmsbuild can you please check and sign again.

epalencia · 2024-03-22T12:03:36Z

Please test

cmsbuild · 2024-03-22T14:56:11Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ccb314/38345/summary.html
COMMIT: a888655
CMSSW: CMSSW_14_0_X_2024-03-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44511/38345/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 114 lines to the logs
Reco comparison results: 58 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3346148
DQMHistoTests: Total failures: 1355
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3344771
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 166 edm output root files, 49 DQM output files
TriggerResults: no differences found

artlbv · 2024-03-23T19:39:27Z

Backport of #44510

artlbv · 2024-03-23T19:40:10Z

To be tested with (I cannot trigger this):

test parameters:

[14_0_X] AXOL1TL v3.0.2 cmsdist#9092, [14_0] Update CICADA external to v1.3.1 to prevent weight overwrite cmsdist#9088

epalencia · 2024-03-25T07:19:42Z

Please test

mmusich · 2024-03-25T07:43:33Z

@cmsbuild, please abort

mmusich · 2024-03-25T07:43:55Z

test parameters:

pull_request = [14_0_X] AXOL1TL v3.0.2 cmsdist#9092, [14_0] Update CICADA external to v1.3.1 to prevent weight overwrite cmsdist#9088

mmusich · 2024-03-25T07:44:11Z

@artlbv, please squash the commits

artlbv · 2024-03-25T14:18:57Z

I will update/squash the commits after the tests are done and the main PR review is done to avoid duplication.

mmusich · 2024-03-26T11:50:17Z

allow @artlbv test rights

mmusich · 2024-03-26T11:50:23Z

@cmsbuild, please test

artlbv · 2024-03-26T11:54:33Z

@mmusich do we still want to test this with the externals? (the backports are not merged yet, though the results will not change in 14_0)

mmusich · 2024-03-26T11:55:38Z

do we still want to test this with the externals?

yes and we are: #44511 (comment)

cmsbuild · 2024-03-26T18:19:51Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ccb314/38424/summary.html
COMMIT: 948a910
CMSSW: CMSSW_14_0_X_2024-03-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44511/38424/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 90 lines from the logs
Reco comparison results: 35 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3346148
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3346126
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 166 edm output root files, 49 DQM output files
TriggerResults: no differences found

aloeliger · 2024-03-26T19:32:08Z

+l1

PR to main branch already signed.

aloeliger · 2024-03-26T19:33:25Z

Actually, @artlbv before I get ahead of myself, did this have the extra string removed? I'm on my phone right now and it's not easy to check.

aloeliger · 2024-03-26T19:34:11Z

Actually, @artlbv before I get ahead of myself, did this have the extra string removed? I'm on my phone right now and it's not easy to check.

Ahh. Looks like it. Sorry for the noise.

artlbv · 2024-03-26T20:32:00Z

Note the externals were already merged:

Martin-Grunewald · 2024-03-27T05:25:10Z

+1

cmsbuild · 2024-03-27T05:25:36Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-03-28T12:14:39Z

+1

cmsbuild added this to the CMSSW_14_0_X milestone Mar 22, 2024

cmsbuild added l1-pending hlt-pending pending-signatures tests-pending orp-pending labels Mar 22, 2024

artlbv mentioned this pull request Mar 22, 2024

AXOL1TL emulator update for L1 Menu parsing with UTMv12 #44510

Merged

cmsbuild added tests-started and removed tests-pending labels Mar 22, 2024

artlbv mentioned this pull request Mar 22, 2024

[14_0_X] Change hls4ml emulator extra version to avoid segfault cms-sw/cmsdist#9065

Merged

cmsbuild added tests-approved and removed tests-started labels Mar 22, 2024

cmsbuild added the backport label Mar 23, 2024

cmsbuild added tests-started and removed tests-approved labels Mar 25, 2024

cmsbuild added tests-pending and removed tests-started labels Mar 25, 2024

cmsbuild added the requires-external label Mar 25, 2024

cmsbuild added tests-started allow-artlbv and removed tests-pending labels Mar 26, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 26, 2024

cmsbuild added l1-approved and removed l1-pending labels Mar 26, 2024

cmsbuild added hlt-approved fully-signed and removed hlt-pending pending-signatures labels Mar 27, 2024

cmsbuild added backport-ok and removed backport labels Mar 27, 2024

cmsbuild added orp-approved and removed orp-pending labels Mar 28, 2024

cmsbuild merged commit 5bb82a5 into cms-sw:CMSSW_14_0_X Mar 28, 2024
11 checks passed

cmsbuild mentioned this pull request Mar 28, 2024

[14.0][BuildRules] fix alpaka/rocm rules cms-sw/cmsdist#9103

Merged

antoniovilela mentioned this pull request Mar 31, 2024

Build CMSSW_14_0_4 #44580

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14_0_0] Backport of #44510 AXOL1TL emulator update for L1 Menu parsing with UTMv12 #44511

[14_0_0] Backport of #44510 AXOL1TL emulator update for L1 Menu parsing with UTMv12 #44511

artlbv commented Mar 22, 2024

cmsbuild commented Mar 22, 2024 •

edited

cmsbuild commented Mar 22, 2024 •

edited

cmsbuild commented Mar 22, 2024

epalencia commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

artlbv commented Mar 23, 2024

artlbv commented Mar 23, 2024 •

edited

epalencia commented Mar 25, 2024

mmusich commented Mar 25, 2024

mmusich commented Mar 25, 2024 •

edited

mmusich commented Mar 25, 2024

artlbv commented Mar 25, 2024

mmusich commented Mar 26, 2024

mmusich commented Mar 26, 2024

artlbv commented Mar 26, 2024

mmusich commented Mar 26, 2024

cmsbuild commented Mar 26, 2024

aloeliger commented Mar 26, 2024

aloeliger commented Mar 26, 2024

aloeliger commented Mar 26, 2024

artlbv commented Mar 26, 2024

Martin-Grunewald commented Mar 27, 2024

cmsbuild commented Mar 27, 2024

antoniovilela commented Mar 28, 2024

[14_0_0] Backport of #44510 AXOL1TL emulator update for L1 Menu parsing with UTMv12 #44511

[14_0_0] Backport of #44510 AXOL1TL emulator update for L1 Menu parsing with UTMv12 #44511

Conversation

artlbv commented Mar 22, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Mar 22, 2024 • edited

cmsbuild commented Mar 22, 2024 • edited

cmsbuild commented Mar 22, 2024

epalencia commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

Comparison Summary

artlbv commented Mar 23, 2024

artlbv commented Mar 23, 2024 • edited

epalencia commented Mar 25, 2024

mmusich commented Mar 25, 2024

mmusich commented Mar 25, 2024 • edited

mmusich commented Mar 25, 2024

artlbv commented Mar 25, 2024

mmusich commented Mar 26, 2024

mmusich commented Mar 26, 2024

artlbv commented Mar 26, 2024

mmusich commented Mar 26, 2024

cmsbuild commented Mar 26, 2024

Comparison Summary

aloeliger commented Mar 26, 2024

aloeliger commented Mar 26, 2024

aloeliger commented Mar 26, 2024

artlbv commented Mar 26, 2024

Martin-Grunewald commented Mar 27, 2024

cmsbuild commented Mar 27, 2024

antoniovilela commented Mar 28, 2024

cmsbuild commented Mar 22, 2024 •

edited

cmsbuild commented Mar 22, 2024 •

edited

artlbv commented Mar 23, 2024 •

edited

mmusich commented Mar 25, 2024 •

edited