Skip to content

Commit

Permalink
Merge pull request #22762 from gartung/RecoMuon-MuonIsolation-fix-cla…
Browse files Browse the repository at this point in the history
…ngwarn

RecoMuon/MuonIsolation: Fixes for these clang warnings: -Wlogical-not-parentheses -Woverloaded-virtual
  • Loading branch information
cmsbuild authored Apr 3, 2018
2 parents 2c577b5 + f3059c7 commit 62f86a2
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions RecoMuon/MuonIsolation/plugins/CaloExtractorByAssociator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@ std::vector<IsoDeposit> CaloExtractorByAssociator::deposits( const Event & event
if (theDepositInstanceLabels.size() != 3){
LogError("MuonIsolation")<<"Configuration is inconsistent: Need 3 deposit instance labels";
}
if (! theDepositInstanceLabels[0].compare(0,1, std::string("e")) == 0
|| ! theDepositInstanceLabels[1].compare(0,1, std::string("h")) == 0
|| ! theDepositInstanceLabels[2].compare(0,2, std::string("ho")) == 0){
if (! (theDepositInstanceLabels[0].compare(0,1, std::string("e")) == 0)
|| ! (theDepositInstanceLabels[1].compare(0,1, std::string("h")) == 0)
|| ! (theDepositInstanceLabels[2].compare(0,2, std::string("ho")) == 0)){
LogWarning("MuonIsolation")<<"Deposit instance labels do not look like (e*, h*, ho*):"
<<"proceed at your own risk. The extractor interprets lab0=from ecal; lab1=from hcal; lab2=from ho";
}
Expand Down

0 comments on commit 62f86a2

Please sign in to comment.