[AlCa/DB] removal of HcalCholeskyMatrix DB object

[kpedro88]

Procedural question for @mmusich and @ggovi:

After #14856, the HcalCholeskyMatrix object is not used anywhere in the HCAL code. What remains is to remove the object from related database code (and from the GTs).

If I make a PR simply deleting every reference to the relevant objects (checking https://github.com/cms-sw/cmssw/search?utf8=%E2%9C%93&q=hcalcholeskymatrices&type=Code and https://github.com/cms-sw/cmssw/search?utf8=%E2%9C%93&q=hcalcholeskymatrix), will that be acceptable from the AlCa/DB side?

Do we need to update the GT in the same PR, or can that happen afterward?

attn: @abdoulline

[cmsbuild]

A new Issue was created by @kpedro88 Kevin Pedro.

@davidlange6, @smuzaffar, @Degano, @davidlt, @Dr15Jones can you please review it and eventually sign/assign? Thanks.

cms-bot commands are list here #13029

[mmusich]

@kpedro88 if you really want to remove it for good the first step is to remove the record from the Global Tag (everywhere it exists), otherwise removing the DB code before cleaning the GT we will have exceptions in the relval tests.
I believe we want to limit ourselves to 81X for the time being.
@ggovi @franzoni feel free to add details.

[abdoulline]

Marco, I'm a bit confused...

I thought we proceed this way (inverting impementation of DB object):
(1) remove it's usage (access from user code) - this one is not used...
(2) remove/desactivate acces from CMSSW to HcalCholeskyMatrix in DB
(3) remove unused (then) DB records
(4) remove definition of the object in CondFormats

So that (1)-(2) can be done in one move, then follows (3) cleanup of DB.
And finally definitions can be removed?

On Thu, 23 Jun 2016, Marco Musich wrote:

@kpedro88 if you really want to remove it for good the first step is to remove the record from the Global Tag
(everywhere it exists), otherwise removing the DB code before cleaning the GT we will have exceptions in the relval
tests.
I believe we want to limit ourselves to 81X for the time being.
@ggovi @franzoni feel free to add details.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the
thread.[AEx02skjFVKa9m7D07g2bKpQbfUEvctoks5qOnUzgaJpZM4I8GVP.gif]

[mmusich]

Salavat the point is that before removing the CondFormat the GT needs to be clean. What you'll do before, disabling access in CMSSW of unused conditions doesn't concern us.

[abdoulline]

OK, thank you.
I just thought (2) is needed at the beginning, as it explicitly initiates (unused) conditions accessing then in DB.
I presume we can proceed with (1)-(4). So that (4) is naturally the last step...

[kpedro88]

@mmusich @ggovi @abdoulline:

#15061 has been merged for a couple of weeks. Whose responsibility is removing the DB records from the GTs, so that we can then remove the CondFormat?

[abdoulline]

@mmusich @ggovi

(1)
whether HCAL (Walter) should send an appropriate request to remove the
rcd records from all the 81X GTs (so far we did send requests only
to add something)

(2)
or Marco and/or Giacomo you would do it on you own at your earliest
convenience?

On Wed, 27 Jul 2016, Kevin Pedro wrote:

@mmusich @ggovi @abdoulline:

#15061 has been merged for a couple of weeks. Whose responsibility is removing the DB records from the GTs, so that
we can then remove the CondFormat?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the
thread.[AEx02vimvKAeJuNBv9zKp8R_qDbcUg2Gks5qZ77ygaJpZM4I8GVP.gif]

[mmusich]

@abdoulline, @kpedro88,
Walter can place a formal request (maybe for book-keeping), but we are aware of this.
We'll work on that and provide updated Global Tags with the desired removal (among other features). Not sure, though, I can make it in time for pre10 (due Aug 1st).

[mmusich]

@smuzaffar can you please assign this issue to category alca?

[smuzaffar]

assign alca

[cmsbuild]

New categories assigned: alca

@mmusich,@cerminar,@franzoni,@ghellwig you have been requested to review this Pull request/Issue and eventually sign? Thanks

[mmusich]

@kpedro88 turns out that we already cleaned up the Global Tags (back in Nov 2014) in this PR:

#6224

in CMSSW_7_3_0_pre2 (!!).

$ conddb search HcalCholeskyMatri
Tag                                                              Time Type  Object Type           Synchronization  Insertion Time       Description                                                                        
---------------------------------------------------------------  ---------  --------------------  ---------------  -------------------  ---------------------------------------------------------------------------------  
HcalCholeskyMatrices_v1.01_mc[cms_orcon_prod/CMS_COND_HCAL_000]  Run        HcalCholeskyMatrices  mc               2012-08-09 17:32:45  USER=popconpro;HOSTNAME=srv-C2C05-11;PWD=/nfshome0/popconpro;                      
HcalCholeskyMatrices_v1.01_mc                                    Run        HcalCholeskyMatrices  any              2010-08-10 11:06:37  USER=diguida;HOSTNAME=lxbuild151.cern.ch;PWD=/build/diguida/ia32/CMSSW_3_8_1/src;  

followed by:

$ conddb listGTsForTag HcalCholeskyMatrices_v1.01_mc  
$ conddb listGTsForTag `HcalCholeskyMatrices_v1.01_mc[cms_orcon_prod/CMS_COND_HCAL_000]`

will convince you, there is nothing there anymore since years.
Please go ahead with your Summer Cleanup.
M.

[mmusich]

+1

[cmsbuild]

This issue is fully signed and ready to be closed.

[abdoulline]

Thanks for checking, Marco!
I had the impression I saw it somewhere, but now looking at several GTs I
don't see it indeed.
And now recall it was once discussed with Salvatore Di Guida (in his
quest of unused conditions)..

On Thu, 28 Jul 2016, Marco Musich wrote:

@kpedro88 turns out that we already cleaned up the Global Tags (back in Nov 2014) in
this PR:

#6224

in CMSSW_7_3_0_pre2 (!!).

$ conddb search HcalCholeskyMatri
Tag Time Type Object Ty
pe Synchronization Insertion Time Description

---

---

---

HcalCholeskyMatrices_v1.01_mc[cms_orcon_prod/CMS_COND_HCAL_000] Run HcalChole
skyMatrices mc 2012-08-09 17:32:45 USER=popconpro;HOSTNAME=srv-C2C05-
11;PWD=/nfshome0/popconpro;
HcalCholeskyMatrices_v1.01_mc Run HcalChole
skyMatrices any 2010-08-10 11:06:37 USER=diguida;HOSTNAME=lxbuild151.c
ern.ch;PWD=/build/diguida/ia32/CMSSW_3_8_1/src;

followed by:

$ conddb listGTsForTag HcalCholeskyMatrices_v1.01_mc
$ conddb listGTsForTag HcalCholeskyMatrices_v1.01_mc[cms_orcon_prod/CMS_COND_HCAL_00 0]

will convince you, there is nothing there anymore since years.
Please go ahead with your Summer Cleanup.
M.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the
thread.[AEx02ps3LHwb2iBdwjATcs4-mAJVxM2lks5qaKLggaJpZM4I8GVP.gif]

[kpedro88]

I will submit a PR soon removing the CondFormat.

[kpedro88]

#15320 is submitted.

[mmusich]

#15320 is merged. @smuzaffar can we close this item? Thanks