new (to me) warnings from ThroughputService

[davidlange6]

Hi @fwyzard

not urgent...

I noticed these in step2 workflows of a recent IB. I don't understand why these would happen from the code.

DQMStore: WARNING: attempt to remove non-existent monitor element 'throughput_retired' in 'HLT/Throughput'
DQMStore: WARNING: attempt to remove non-existent monitor element 'throughput_sourced' in 'HLT/Throughput'

[cmsbuild]

A new Issue was created by @davidlange6 David Lange.

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[fwyzard]

I'll take a look, but not too soon :-(

[fwyzard]

How do I assign it to myself ?

[Dr15Jones]

I think we only assign categories, not people

[Dr15Jones]

The first cmsbot message of this thread gives a link to the commands one can give http://cms-sw.github.io/cms-bot-cmssw-issues.html

[fwyzard]

I get the same warnings in 9.2.0 for the FastTimerService:

DQMStore: WARNING: attempt to remove non-existent monitor element 'event allocated' in 'HLT/TimerService'
DQMStore: WARNING: attempt to remove non-existent monitor element 'event allocated_byls' in 'HLT/TimerService'
DQMStore: WARNING: attempt to remove non-existent monitor element 'event deallocated' in 'HLT/TimerService'
DQMStore: WARNING: attempt to remove non-existent monitor element 'event deallocated_byls' in 'HLT/TimerService'
...

Did anything change with the way DQM or DQMSaver handle histograms between 9.1.x and 9.2.x ?

[Dr15Jones]

I think around that time the DQMStore was changed to try to catch cases where DQM modules failed to set the directory to which they were putting their histograms.

[davidlange6]

I had the same thought - the PR was #18562

…

On May 20, 2017, at 5:54 PM, Chris Jones ***@***.***> wrote: I think around that time the DQMStore was changed to try to catch cases where DQM modules failed to set the directory to which they were putting their histograms. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[Dr15Jones]

I have a theory as to what might have happened. The FastTimerService calls the pwd method from DQM which ultimately just returns the member data of DQMStore. If another thread called a module which was talking directly to the DQMStore without going through the IBooker or IGetter interface, it could change the value of the member data without taking the lock. Then when FastTimerService calls pwd it would get the wrong answer.

[fwyzard]

Mhm, that would not explain why David is seeing the message for the ThroughputService - which does not call pwd():

    // define a callback that can book the histograms
    auto bookTransactionCallback = [&, this] (DQMStore::IBooker & booker) {
      booker.setCurrentFolder(m_dqm_path);
      stream.sourced_events = booker.book1D("throughput_sourced",  "Throughput (sourced events)",   bins, 0., range)->getTH1F();
      stream.sourced_events ->SetXTitle("time [s]");
      stream.sourced_events ->SetYTitle(y_axis_title.c_str());
      stream.retired_events = booker.book1D("throughput_retired",  "Throughput (retired events)",   bins, 0., range)->getTH1F();
      stream.retired_events ->SetXTitle("time [s]");
      stream.retired_events ->SetYTitle(y_axis_title.c_str());
    };

[Dr15Jones]

assign hlt

[cmsbuild]

New categories assigned: hlt

@Martin-Grunewald,@silviodonato,@fwyzard you have been requested to review this Pull request/Issue and eventually sign? Thanks

[smuzaffar]

@davidlange6 , do you still see these warnings?

[davidlange6]

I have no idea…sorry On May 28, 2020, at 7:58 PM, Malik Shahzad Muzaffar <notifications@github.com<mailto:notifications@github.com>> wrote: @davidlange6<https://github.com/davidlange6> , do you still see these warnings? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#18850 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQZPJAVX33ZNCJX5TGLRT2Q5RANCNFSM4DMBNVTA>.

[smuzaffar]

sreaching in all runTheMatrix logs does not show any occurrence of DQMStore: WARNING:` .
I am closing this issue, please open a new open if you again see such warnings.

[a]

> find . -name '*.log' | wc -l
8623
> grep -Ri 'DQMStore: WARNING:' . | wc -l
0