Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset the path in DQMStore for each module #18562

Merged
merged 1 commit into from May 10, 2017

Conversation

dmitrijus
Copy link
Contributor

@dmitrijus dmitrijus commented May 4, 2017

When modules book the monitor elements, they have to set the path first.

However, for several modules, it is not done.
In such case, the folder they book histograms in is neither predictable nor consistent.
And the monitor elements appear not they were belong...
(and depends on the last module who acquired the booking lock)

First commit to see how bad it really is,
I will add more commits once I identity the modules without this path set.

@dmitrijus
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19561/console Started: 2017/05/04 11:12

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

A new Pull Request was created by @dmitrijus (Dmitrijus) for master.

It involves the following packages:

DQMServices/Core

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor Author

please abort test

@dmitrijus
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19562/console Started: 2017/05/04 11:41

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18562/19562/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1652 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1834941
  • DQMHistoTests: Total failures: 40527
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1794234
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@dmitrijus
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19678/console Started: 2017/05/09 16:04

@dmitrijus
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18562/19678/summary.html

Comparison Summary:

  • You potentially added 5370 lines to the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1830172
  • DQMHistoTests: Total failures: 46525
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1783467
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 634f58c into cms-sw:master May 10, 2017
This was referenced May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants