Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkdeps reverts code pull? #34

Closed
cerati opened this issue Jul 4, 2013 · 6 comments
Closed

checkdeps reverts code pull? #34

cerati opened this issue Jul 4, 2013 · 6 comments

Comments

@cerati
Copy link
Contributor

cerati commented Jul 4, 2013

Ciao,
if I run git cms-checkdeps -a the code changes that I got from git pull my-cmssw my-branch are overwritten, see the example below.
Is this expected? How can I avoid this behavior?
Thanks,
Giuseppe

cmsrel CMSSW_7_0_0_pre0
cd CMSSW_7_0_0_pre0/src
cmsenv
git cms-addpkg TrackingTools/AnalyticalJacobians
git cms-addpkg TrackingTools/TrajectoryParametrization
head -n 12 TrackingTools/TrajectoryParametrization/interface/GlobalTrajectoryParameters.h

ifndef TRACKER_GLOBALTRAJECTORYPARAMETERS_H

define TRACKER_GLOBALTRAJECTORYPARAMETERS_H

include "DataFormats/GeometryVector/interface/GlobalPoint.h"

include "DataFormats/GeometryVector/interface/GlobalVector.h"

include "DataFormats/TrajectoryState/interface/TrackCharge.h"

include "DataFormats/Math/interface/AlgebraicROOTObjects.h"

class MagneticField;

/** Class providing access to a set of relevant parameters of a trajectory
in the global, Cartesian frame. The basic data members used to calculate

git pull my-cmssw cacheMFinGTP
head -n 12 TrackingTools/TrajectoryParametrization/interface/GlobalTrajectoryParameters.h

ifndef TRACKER_GLOBALTRAJECTORYPARAMETERS_H

define TRACKER_GLOBALTRAJECTORYPARAMETERS_H

include "DataFormats/GeometryVector/interface/GlobalPoint.h"

include "DataFormats/GeometryVector/interface/GlobalVector.h"

include "DataFormats/TrajectoryState/interface/TrackCharge.h"

include "DataFormats/Math/interface/AlgebraicROOTObjects.h"

// Can move the second constructor to .cc, too ... or make all
// functions inline?
// class MagneticField;

include "MagneticField/Engine/interface/MagneticField.h"

git cms-checkdeps -a
head -n 12 TrackingTools/TrajectoryParametrization/interface/GlobalTrajectoryParameters.h

ifndef TRACKER_GLOBALTRAJECTORYPARAMETERS_H

define TRACKER_GLOBALTRAJECTORYPARAMETERS_H

include "DataFormats/GeometryVector/interface/GlobalPoint.h"

include "DataFormats/GeometryVector/interface/GlobalVector.h"

include "DataFormats/TrajectoryState/interface/TrackCharge.h"

include "DataFormats/Math/interface/AlgebraicROOTObjects.h"

class MagneticField;

/** Class providing access to a set of relevant parameters of a trajectory
in the global, Cartesian frame. The basic data members used to calculate

@ktf
Copy link
Contributor

ktf commented Jul 4, 2013

A similar issue has been reported by David Dagenhart:

scram project CMSSW_7_0_0_pre0
cd CMSSW_7_0_0_pre0/src/
cmsenv
git cms-addpkg FWCore/Framework
emacs FWCore/Framework/BuildFile.xml &
(edit only that file)
git merge official-cmssw/CMSSW_7_0_X
git cms-addpkg FWCore/Utilities
% git status
# On branch my-new-feature
# Changes to be committed:
#   (use "git reset HEAD <file>..." to unstage)
#
#       deleted:    .gitignore
#       modified:   DQMServices/Components/python/ROOTData.py
#       deleted:    FWCore/Framework/interface/ConsumesCollector.h
#       modified:   FWCore/Framework/interface/EDConsumerBase.h
#       modified:   FWCore/Framework/src/EDConsumerBase.cc
#       modified: FWCore/Framework/test/edconsumerbase_t.cppunit.cc
#       modified:   FWCore/Framework/test/stubs/TestMergeResults.cc
#       modified:   FWCore/Integration/test/run_RunMerge.sh
#       deleted: FWCore/Integration/test/testRunMergeMERGE5_cfg.py
#       deleted:    FWCore/Integration/test/testRunMergeTEST5_cfg.py
#       modified:   FWCore/ParameterSet/python/Types.py
#       modified:   FWCore/ParameterSet/python/Utilities.py
#
# Changes not staged for commit:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working
directory)
#
#       modified:   FWCore/Framework/BuildFile.xml
#
# Untracked files:
#   (use "git add <file>..." to include in what will be committed)
#
#       FWCore/Framework/BuildFile.xml~

looking into it.

@ktf
Copy link
Contributor

ktf commented Jul 4, 2013

Also @rovere reports the same issue.

@ktf
Copy link
Contributor

ktf commented Jul 4, 2013

I think I've understood what goes wrong, I need to think more on how to fix it.

@ktf
Copy link
Contributor

ktf commented Jul 5, 2013

Ciao, I think I have a fix for it. Can you try out the bleeding edge version:

git clone https://github.com/cms-sw/cms-git-tools.git
export PATH=$PWD/cms-git-tools:$PATH
export MANPATH=$PWD/cms-git-tools:$MANPATH

and check it behaves correctly?

@ktf
Copy link
Contributor

ktf commented Jul 5, 2013

BTW, this should now be done more easily via:

git cms-merge-topic cerati:cacheMFinGTP
git cms-checkdeps -a

@cerati
Copy link
Contributor Author

cerati commented Jul 8, 2013

Thanks a lot it works!
Giuseppe

@cerati cerati closed this as completed Jul 8, 2013
dildick referenced this issue in gem-sw/cmssw Sep 26, 2013
Update trigger plots and fix the GEM simhit and digi validation tools
yetkinyilmaz referenced this issue in CmsHI/cmssw Dec 23, 2013
Update RSGravitonToDijets_kMpl01_M_5000_Tune4C_13TeV_pythia8_cfi.py
nclopezo pushed a commit to nclopezo/cmssw that referenced this issue May 5, 2014
Adding thuer to generators watcher and moving IOMC/ParticleGuns to gener...
franzoni pushed a commit to franzoni/cmssw that referenced this issue May 8, 2014
geonmo pushed a commit to geonmo/cmssw that referenced this issue Jul 25, 2014
Change to JpsiToMuMuProducer.
jpata referenced this issue in jpata/cmssw Mar 13, 2015
arizzi referenced this issue in arizzi/cmssw May 8, 2015
CMG updates for  Heppy 72X (as of 7 May 2015)
yetkinyilmaz pushed a commit to yetkinyilmaz/cmssw that referenced this issue Dec 9, 2015
baffioni pushed a commit to baffioni/cmssw that referenced this issue Jun 22, 2016
cmsbuild pushed a commit that referenced this issue Sep 30, 2016
mileva pushed a commit to mileva/cmssw that referenced this issue Apr 6, 2017
mariadalfonso pushed a commit to mariadalfonso/cmssw that referenced this issue May 6, 2017
fwyzard pushed a commit to fwyzard/cmssw that referenced this issue Mar 27, 2018
Matrix operations are based on Eigen.

A first GPU version, running Eigen together with CUDA, is available in the test directory but currently disabled.
Sam-Harper added a commit to Sam-Harper/cmssw that referenced this issue Mar 4, 2019
Fixing MVA V2 isol values not being present & tools updates
cihar29 pushed a commit to cihar29/cmssw that referenced this issue Mar 5, 2019
oglez pushed a commit to oglez/cmssw that referenced this issue Jun 15, 2019
¡Minor change to definition of primo
gpetruc added a commit to gpetruc/cmssw that referenced this issue Jun 30, 2020
adding selection options for sorting correlator layer 1 inputs and outputs and cutting on output multiplicity
franzoni pushed a commit to franzoni/cmssw that referenced this issue May 3, 2021
Add "includeHaloPCA" flag for ntup template
drankincms pushed a commit to drankincms/cmssw that referenced this issue Mar 9, 2022
hqucms pushed a commit to hqucms/cmssw that referenced this issue Jul 26, 2023
…NO-13_2_0_pre2_speedup_nano

Speed up Nano further
vince502 pushed a commit to vince502/cmssw that referenced this issue Sep 12, 2023
sroychow pushed a commit to erc-asymow/cmssw that referenced this issue Mar 19, 2024
Reduced the general track cut from 15 to 10 GeV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants