New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rpc and irpc digitization phase ii #14769
Rpc and irpc digitization phase ii #14769
Conversation
A new Pull Request was created by @bapavlov for CMSSW_8_1_X. It involves the following packages: DataFormats/RPCDigi @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@bapavlov , there are few comments to this PR (all are minor): |
Pull request #14769 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
Pull request #14769 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again. |
@bapavlov should I restart tests? |
@bapavlov you have to be on this list to control the bot: |
@cmsbuild please test |
@kpedro88 yes, please restart. I have put wrong muonRPCDigis_cfi.py file. I have updated it. The same tests are passing on lxplus with the new muonRPCDigis_cfi.py file. |
The tests are being triggered in jenkins. |
Comparison is ready There are some workflows for which there are errors in the baseline: |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
@davidlange6 reminder to merge... |
@davidlange6 why is this not merged yet? |
+1 |
A new digi format to simulate the new type of RPCs ( iRPCs) and the new RPC electronics for 2023 upgrade. Also a digi model to simulate the iRPCs and the new electronics is included. The digi model allows to simulate the precise timing expected to be achieved with TDC readout (to be installed for 2023 upgrade).
Everything is working (both with CMSSW_8_1_0_pre5 and CMSSW_8_1_0_pre6), including also the reco step.
The code is essential for RPC upgrade studies.