-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline crashes in {HLT,L1}TriggerJSONMonitoring
in CMSSW_14_0_6_MULTIARCHS
#44975
Comments
cms-bot internal usage |
A new Issue was created by @mmusich. @antoniovilela, @sextonkennedy, @rappoccio, @Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
Does the same crash happen in plain |
yes. |
assign hlt |
New categories assigned: hlt @Martin-Grunewald,@mmusich you have been requested to review this Pull request/Issue and eventually sign? Thanks |
assign daq |
It doesn't crash if this is appended:
along with From the code it is not clear why it would crash. |
It is not that, even if removing check for the FMS service there is still a crash. |
Indeed, hltGetConfiguration removes these (see https://github.com/cms-sw/cmssw/blob/master/HLTrigger/Configuration/python/Tools/confdb.py#L809)
It is recommended to use |
I ran this now on a FU machine (with a GPU) and I'm getting a bit different stack trace with more information:
Here it seems that it tries to use Json::Value from the tensorflow library, while we have an integrated (older and modified for thread safety) version in I think what happens is, when EventFilter/Utilities library is loaded by using services, correct version is used and there is no crash. |
Sounds like a one-definition rule violation. If the copy |
I wouldn't dare to change to a different version in the short term, and in the long term we were already thinking of evaluating different json implementations. |
In other CMSSW packages we've been using https://github.com/nlohmann/json , which is available as an external via |
Updated in: #44989 |
Crash is gone with 14_0_6 with the backport. I'll open backport PR as well. |
proposed fixes are merged:
|
@cms-sw/daq-l2 this issue could be closed, right? |
+1 |
This issue is fully signed and ready to be closed. |
@cmsbuild, please close |
@silviodonato reported a crash in
CMSSW_14_0_6_MULTIARCHS
when running:concerning:
Trying to reproduce with a slightly different setup (e.g. the script below)
I get a different crash (also on CPU-only) involving
As additional information, it looks like it depends on the output configuration.
Setting:
--output full
[*] caveat at https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideGlobalHLT#General_Usage--output minimal
--output none
it runs without problems, whereas setting:
--output all
it crashes are reported above.
FYI @missirol @fwyzard @cms-sw/hlt-l2
The text was updated successfully, but these errors were encountered: