modified PR for newOfflinePuID

[jbrands]

This is the subsequent PR of #10330 (comment)

This request is for including the new offline pu Id weights.
There's a new parameter set in RecoJets/JetProducers/python/puJetIDAlgo_cff.py
I included a new variable "etaBinnedWeights" because the new weights a trained for 4 different eta regions.

The new variables are included in RecoJets/JetProducers/src/PileupJetIdAlgo.cc

The code can be checked with RecoJets/JetProducers/test/testJetTools_cfg.py

I did the runTheMatrix.py offline check without error messages

Some discrimination plots can be find in:
http://www.hephy.at/user/jbrandstetter/

[cmsbuild]

A new Pull Request was created by @jbrands for CMSSW_7_6_X.

modified PR for newOfflinePuID

It involves the following packages:

DataFormats/JetReco
PhysicsTools/PatAlgos
RecoJets/JetProducers

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @yslai, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 4ce8a72
When I ran the RelVals I found an error in the following worklfows:
135.4 step3

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

4.53 step5

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT/step5_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT.log

1306.0 step5

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step5_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log

1330.0 step5

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step5_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log

50202.0 step5

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550/step5_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550.log

25202.0 step5

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step5_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10398/6647/summary.html

[slava77]

PAT steps are broken:

PhysicsTools/PatAlgos/slimming/pileupJetId_cfi.py", line 3, in <module>
    from RecoJets.JetProducers.PileupJetIDParams_cfi import full_74x_chs
ImportError: cannot import name full_74x_chs

[ahinzmann]

Should be fixed now.

[cmsbuild]

Pull request #10398 was updated. @cvuosalo, @monttj, @cmsbuild, @deguio, @slava77, @vadler, @danduggan can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 2178190
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10398/193363/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10398/193363/summary.html

[slava77]

for #10398 2178190

• code changes are OK now
• jenkins tests pass and comparisons with baseline show differences only in miniAOD (we have miniAOD DQM in IBs now. Nice!)
  Here's just a random plot from 25202 (ttbar pu 35@25ns)
  

Memory check based on CMSSW_7_6_X_2015-08-04-2300 /test area test10398/
running PromptReco (--reco --miniaod --aod --dqmio --alcareco TkAlMuonIsolated+HcalCalIterativePhiSym+DtCalib+MuAlCalIsolatedMu+MuAlOverlaps+MuAlZMuMu) config on /store/data/Run2015B/DoubleMuon/RAW/v1/000/251/721/00000/44C77595-412A-E511-930E-02163E012A2C.root

MEM_LIVE on 10 events actually shows a 5 MB decrease:
https://slava77sk.web.cern.ch/slava77sk/reco/cgi-bin/igprof-navigator/CMSSW_7_6_X_2015-08-04-2300-orig-251721.10evts

1,963,723,113   6,989,059   main
32,763,366  259,038 PileupJetIdProducer::produce(edm::Event&, edm::EventSetup const&)
29,160,490  230,596 PileupJetIdAlgo::computeMva()
34,113,684  264,357 PileupJetIdAlgo::bookReader()

https://slava77sk.web.cern.ch/slava77sk/reco/cgi-bin/igprof-navigator/CMSSW_7_6_X_2015-08-04-2300-test10398-251721.10evts

1,959,849,143   6,962,039   main
29,852,808  240,362 PileupJetIdProducer::produce(edm::Event&, edm::EventSetup const&)
29,160,490  230,596 PileupJetIdAlgo::computeMva()
29,446,412  233,018 PileupJetIdAlgo::bookReader(float)

[ahinzmann]

@slava77 Is this a +1?

[slava77]

+1

@ahinzmann thanks for noticing
I was pasting a summary incrementally and missed the most important piece

[monttj]

+1

[slava77]

@deguio please check this one
there is an interference with another PR in the queue and I wanted this one to go first since it has running code.