Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of new pileup jet ID for MiniAOD re-processing #11007

Merged
merged 15 commits into from Sep 2, 2015

Conversation

ahinzmann
Copy link
Contributor

Backport of the following PRs:
#10398 jbrands:newOfflinePuID_new
#10730 ahinzmann:fixpuid
#10625 ahinzmann:PUjetIDcleanup76
#10923 ahinzmann:pileupjetiddqm76

They contain a new training of the pileup jet ID with 74 MC.
This is not the final/optimal training, but already better than the 53 training on 74 MC (ROC curves are in #10625). Optimization of a working point for MVAmet is also not yet done, thus it is not configured to be used in MVAmet.

runTheMatrix -l limited works in CMSSW_7_4_10_patch1

@gpetruc this can be included in the MiniAOD processing

@slava77
Copy link
Contributor

slava77 commented Aug 28, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ahinzmann for CMSSW_7_4_X.

Backport of new pileup jet ID for MiniAOD re-processing

It involves the following packages:

DQM/PhysicsHWW
DQMOffline/JetMET
DataFormats/JetReco
PhysicsTools/PatAlgos
RecoJets/JetProducers
RecoMET/METPUSubtraction

@cvuosalo, @monttj, @cmsbuild, @deguio, @slava77, @vadler, @danduggan can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @yslai, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ahinzmann
Copy link
Contributor Author

@slava77 maybe this needs another triggering of tests, since I included one commit a minute after the test was requested

@slava77
Copy link
Contributor

slava77 commented Aug 28, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@monttj
Copy link
Contributor

monttj commented Aug 30, 2015

+1
This is backport from 76X PRs which are already approved.

@slava77
Copy link
Contributor

slava77 commented Sep 1, 2015

+1

for #11007 e00bc47

  • backport contains changes from the 76X PRs as described
  • jenkins tests pass and comparisons with baseline show differences only in DQM plots in cleaned jets and in PU-ID variables, as expected (monitored RECO products are unchanged)
  • the list of products stored in RECO/AOD output and their size is unchanged

@slava77
Copy link
Contributor

slava77 commented Sep 1, 2015

@deguio @danduggan please check this PR

@deguio
Copy link
Contributor

deguio commented Sep 2, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 2, 2015
Backport of new pileup jet ID for MiniAOD re-processing
@cmsbuild cmsbuild merged commit aaa4640 into cms-sw:CMSSW_7_4_X Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants