RCT unpacker plus DQM 74X #10880
Closed
RCT unpacker plus DQM 74X #10880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Delete old, very outdated files
At the request of L1 offline software folks For the record, I think this could possibly cause issues in legacy code, due to the emulator previously being called 'rctDigis' rather than the preferred 'simRctDigis'
Plus better plot labeling for digi source
|
please test |
|
The tests are being triggered in jenkins. |
|
Pull request #10880 was updated. @cmsbuild, @danduggan, @mulhearn, @deguio can you please check and sign again. |
|
+1 |
|
+1 |
cmsbuild
added
l1-approved
fully-signed
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
@davidlange6 these have been in 76X for awhile now. Merge? |
|
@davidlange6 please leave this one open during data taking, even if you do not merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-make of #10381 due to merge conflict in upstream
DQM/Integrationpackage75X: #10881
76X: #10882