Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCT unpacker plus DQM 75X #10881

Merged
merged 36 commits into from
Oct 20, 2015
Merged

Conversation

nsmith-
Copy link
Contributor

@nsmith- nsmith- commented Aug 20, 2015

Re-make of #10631
75X version of #10880

mcepeda and others added 30 commits July 30, 2015 17:18
+ Delete old, very outdated files
At the request of L1 offline software folks
For the record, I think this could possibly cause issues in
legacy code, due to the emulator previously being called 'rctDigis'
rather than the preferred 'simRctDigis'
Due to merge conflict with 9a95bb2
@mulhearn
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #10881 was updated. @cmsbuild, @danduggan, @mulhearn, @deguio can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Sep 16, 2015

+1
but needs to prove that it works fine in 76

@mulhearn
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@mulhearn
Copy link
Contributor

@davidlange6 these have been in 76X for some time. Can you merge please?

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 20, 2015
@cmsbuild cmsbuild merged commit 8e7c516 into cms-sw:CMSSW_7_5_X Oct 20, 2015
@nsmith- nsmith- deleted the RCTDQMupdates75X branch March 21, 2016 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants